63264[FEATURE] Add form field-name VH to replace current form VHs
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 36
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-90386-FormFieldRelatedViewHelpers.rstnew+57 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-90386-FormFieldNameViewHelperToReplaceFformScopeViewHelpers.rstnew+29 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptgroupViewHelper.php+5 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+5 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+9 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/FieldNameViewHelper.phpnew+108 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php+3 −0
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/Fixtures/ClassWithTwoGetters.phprenamed+3 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/Fixtures/EmptyClass.phprenamed+3 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/Fixtures/EmptySyntaxTreeNode.phprenamed+6 −3
Show 16 more files
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/Fixtures/ExtendsAbstractEntity.phprenamed+4 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/Fixtures/UserDomainClass.phprenamed+3 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/Select/OptionViewHelperTest.phprenamed+3 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/AbstractFormFieldViewHelperTest.phprenamed+18 −13
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/AbstractFormViewHelperTest.phprenamed+18 −15
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/ButtonViewHelperTest.phprenamed+2 −1
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/CheckboxViewHelperTest.phprenamed+2 −1
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/FormFieldViewHelperBaseTestcase.phprenamed+2 −1
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/HiddenViewHelperTest.phprenamed+4 −3
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/PasswordViewHelperTest.phprenamed+9 −5
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/RadioViewHelperTest.phprenamed+3 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/SelectViewHelperTest.phprenamed+2 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/SubmitViewHelperTest.phprenamed+6 −4
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/TextareaViewHelperTest.phprenamed+2 −1
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/TextfieldViewHelperTest.phprenamed+2 −2
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/Form/UploadViewHelperTest.phprenamed+8 −5
Review log 1927
Show 12 earlier messages
-
Claus Due uploaded patch set 1 02/15/20, 19:11
-
TYPO3com voted on patch set 1 V -1 02/15/20, 19:11 Completed build in 23s on Sat, 15 Feb, 07:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-137
-
Claus Due uploaded patch set 2 02/15/20, 19:23
-
TYPO3com voted on patch set 2 V -1 02/15/20, 19:24 Completed build in 21s on Sat, 15 Feb, 07:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-138
-
Claus Due uploaded patch set 3 02/15/20, 19:33
-
Claus Due updated the commit message in patch set 4 02/15/20, 19:35
-
TYPO3com voted on patch set 3 V +1 02/15/20, 19:47 Completed build in 14m 00s on Sat, 15 Feb, 07:47 PM Test Summary: 71293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-140
-
TYPO3com voted on patch set 4 V +1 02/15/20, 19:54 Completed build in 16m 07s on Sat, 15 Feb, 07:54 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-141
-
Anja Leichsenring commented on patch set 4 CR -1 02/15/20, 20:28
reworking the rst files currently -
Anja Leichsenring uploaded patch set 5 02/15/20, 21:33
-
TYPO3com voted on patch set 5 V -1 02/15/20, 21:33 Completed build in 34s on Sat, 15 Feb, 09:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-151
-
Anja Leichsenring uploaded patch set 6 02/15/20, 21:34
-
TYPO3com voted on patch set 6 V -1 02/15/20, 22:00 Completed build in 25m 48s on Sat, 15 Feb, 10:00 PM Test Summary: 462 of 71751 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-152
-
Anja Leichsenring uploaded patch set 7 02/15/20, 22:08
-
Anja Leichsenring commented on patch set 8 02/15/20, 22:15
Published edit on patch set 7. -
Anja Leichsenring voted on patch set 8 V +1 CR +1 02/15/20, 22:19
-
TYPO3com voted on patch set 7 V -1 02/15/20, 22:22 Completed build in 13m 23s on Sat, 15 Feb, 10:22 PM Test Summary: 1 of 71461 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-153
-
TYPO3com voted on patch set 8 V +1 02/15/20, 22:35 Completed build in 17m 11s on Sat, 15 Feb, 10:35 PM Test Summary: 71007 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-154
-
Mathias Brodala commented on patch set 8 V -1 02/17/20, 07:30
Maybe I'm missing something but the form field name is only 50% of the logic. Having form fields automatically pick up the current/last value of related object properties is the other 50%. I cannot see how to reproduce this if the field viewhelpers are dropped. -
Mathias Brodala commented on patch set 8 02/17/20, 07:48
> Patch Set 8: Verified-1 > > Maybe I'm missing something but the form field name is only 50% of the logic. Having form fields automatically pick up the current/last value of related object properties is the other 50%. I cannot see how to reproduce this if the field viewhelpers are dropped. We'd also need a solution for boolean attributes. -
Claus Due commented on patch set 8 V -1 02/19/20, 08:29
You're right Mathias, we need some solution for loading existing value. I'll consider this and if there is no clean solution, un-deprecate the old ViewHelpers but still add the new field name VH as alternative when you want to write field markup that the old ViewHelpers don't support. Regarding the boolean properties, that's actually why I created this patch - we keep adding custom arguments for ViewHelpers which render XHTML booleans and that's what I wanted to avoid initially. TagBuilder does have the "ignoreEmpty" feature and "additionalAttributes" can be used to serve XHTML boolean properties that way - but it still only works inside a (tag-based) ViewHelper. Let's put this on hold temporarily. -
Martin Kutschker commented on patch set 8 12/15/20, 17:13
Unresolved
Why has every name in Fluid be so long? name="{f:form.fieldName(property: 'myProperty')}" Shorter and still reabable: name="{f:form.field(property: 'myProperty')}" -
Oliver Hader commented on patch set 8 10/20/21, 16:02
What's the plan here? Shall we abandon this one? -
Benni Mack wrote 11/29/21, 10:11
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 9 11/29/21, 13:30
-
Christian Kuhn commented on patch set 9 12/09/21, 01:05
Hey. I hope it's ok to abandon this approach for now due to lack of work on this approach. -
Christian Kuhn abandoned the change 12/09/21, 01:05