63266[TASK] Refactor html tag rendering in PageLayoutController
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 56
-
Nikita Hovratov uploaded patch set 1 02/15/20, 21:07
-
TYPO3com voted on patch set 1 V +1 02/15/20, 21:20 Completed build in 13m 03s on Sat, 15 Feb, 09:20 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-150
-
Claus Due commented on patch set 1 02/16/20, 20:45
Looks okay to me but I think we should let someone else chip in: I'm not entirely sure it's alright to mix Fluid's TagBuilder into non-Fluid context in the core... -
Benni Mack commented on patch set 1 02/16/20, 23:01
don't see a huge benefit here tbh. We do this across the whole backend code. I guess we should consider going into a more component based approach than using Fluid TagBuilder directly in this one controller. -
Nikita Hovratov commented on patch set 1 02/18/20, 17:50
> Patch Set 1: > > don't see a huge benefit here tbh. We do this across the whole backend code. I guess we should consider going into a more component based approach than using Fluid TagBuilder directly in this one controller. I see. Let's wait for a more sophisticated approach then. I close this then. -
Nikita Hovratov abandoned the change 02/18/20, 17:51
Wait for a more sophisticated approach