63267[TASK] Simplify API for checking link target
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst4new+34 −0
- typo3/sysext/linkvalidator/Classes/EventListener/CheckBrokenRteLinkEventListener.php+2 −4
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php4+33 −1
Review log 1722
-
Sybille Peters uploaded patch set 1 02/16/20, 08:12
-
TYPO3com voted on patch set 1 V +1 02/16/20, 08:25 Completed build in 13m 29s on Sun, 16 Feb, 08:25 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-160
-
Sybille Peters uploaded patch set 2 02/16/20, 10:23
-
TYPO3com voted on patch set 2 V +1 02/16/20, 10:38 Completed build in 15m 38s on Sun, 16 Feb, 10:38 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-164
-
Georg Ringer commented on patch set 2 CR -1 02/16/20, 20:33
-
Benni Mack commented on patch set 2 02/16/20, 23:04
BrokenLinkRepository.php:37ReplyWe only added this in master, so that's OK IMHO -
Georg Ringer commented on patch set 2 02/17/20, 15:22
BrokenLinkRepository.php:37Replyyeah we are all sometimes lazy but hey we should eat our own dogfood .. -
Sybille Peters commented on patch set 2 02/17/20, 16:17
BrokenLinkRepository.php:37Reply UnresolvedThe function was added with the event in 10.2. But, it is not much extra work to deprecate the function now and remove it later. -
Sybille Peters uploaded patch set 3 02/17/20, 16:28
-
TYPO3com voted on patch set 3 V -1 02/17/20, 16:29 Completed build in 22s on Mon, 17 Feb, 04:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-215
-
Georg Ringer commented on patch set 3 02/17/20, 18:10
Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:18Unresolvednot sure about that ;) -
Sybille Peters commented on patch set 3 02/17/20, 18:14
Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:18Unresolvedgood grief! Not intentional. -
Sybille Peters uploaded patch set 4 02/17/20, 18:19
-
TYPO3com voted on patch set 4 V -1 02/17/20, 18:20 Completed build in 23s on Mon, 17 Feb, 06:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-219
-
Sybille Peters uploaded patch set 5 02/17/20, 18:21
-
TYPO3com voted on patch set 5 V +1 02/17/20, 18:35 Completed build in 13m 17s on Mon, 17 Feb, 06:34 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-220
-
Benni Mack voted on patch set 5 V +1 CR +1 02/20/20, 23:11
-
Georg Ringer voted on patch set 5 V +2 CR +2 02/21/20, 06:29
-
Georg Ringer merged patch set 6 02/21/20, 06:29
-
Sybille Peters commented on patch set 6 02/21/20, 06:32
arg!! I just noticed the text in the migration is wrong. Should be isLinkTargetBrokenLink() instead of "Use :php:`BrokenLinkRepository::getNumberOfBrokenLinks()` instead." -
Julian Hofmann commented on patch set 6 02/21/20, 15:15
Instruction for migration makes no sense.Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:32UnresolvedUsing the deprecated method instead of the deprecated method wouldn't change anything. -
Sybille Peters commented on patch set 6 02/21/20, 17:18
Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:32UnresolvedRight. I noticed that around the time this got merged, see my previous comment. Will have to get fixed in another patch. Sorry about the mess :(
BrokenLinkRepository.php:37