Review main Merged

63267[TASK] Simplify API for checking link target

Sybille Peters CR +2 V +2 Normal +69 −5 updated 02/21/20, 17:18

Commit message

Previously, the function BrokenLinkRepository::getNumberOfBrokenLinks()
was used in the event listener. It is not necessary to return the count.
We now only check if the link target is in the list of broken links.

This makes the API easier to read and reduces the number of methods
with similar and misleading names.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1722

  1. Sybille Peters uploaded patch set 1 02/16/20, 08:12

  2. TYPO3com voted on patch set 1 V +1 02/16/20, 08:25 Completed build in 13m 29s on Sun, 16 Feb, 08:25 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-160

  3. Sybille Peters uploaded patch set 2 02/16/20, 10:23

  4. TYPO3com voted on patch set 2 V +1 02/16/20, 10:38 Completed build in 15m 38s on Sun, 16 Feb, 10:38 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-164

  5. Georg Ringer commented on patch set 2 CR -1 02/16/20, 20:33

    BrokenLinkRepository.php:37

    the class is NOT marked as internal, therefore this is public api and you can't just change public methods. please deprecate the old one and create a new one
  6. Benni Mack commented on patch set 2 02/16/20, 23:04

    BrokenLinkRepository.php:37 Reply

    We only added this in master, so that's OK IMHO
  7. Georg Ringer commented on patch set 2 02/17/20, 15:22

    BrokenLinkRepository.php:37 Reply

    yeah we are all sometimes lazy but hey we should eat our own dogfood ..
  8. Sybille Peters commented on patch set 2 02/17/20, 16:17

    BrokenLinkRepository.php:37 Reply Unresolved

    The function was added with the event in 10.2. But, it is not much extra work to deprecate the function now and remove it later.
  9. Sybille Peters uploaded patch set 3 02/17/20, 16:28

  10. TYPO3com voted on patch set 3 V -1 02/17/20, 16:29 Completed build in 22s on Mon, 17 Feb, 04:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-215

  11. Georg Ringer commented on patch set 3 02/17/20, 18:10

    Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:18 Unresolved

    not sure about that ;)
  12. Sybille Peters commented on patch set 3 02/17/20, 18:14

    Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:18 Unresolved

    good grief! Not intentional.
  13. Sybille Peters uploaded patch set 4 02/17/20, 18:19

  14. TYPO3com voted on patch set 4 V -1 02/17/20, 18:20 Completed build in 23s on Mon, 17 Feb, 06:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-219

  15. Sybille Peters uploaded patch set 5 02/17/20, 18:21

  16. TYPO3com voted on patch set 5 V +1 02/17/20, 18:35 Completed build in 13m 17s on Mon, 17 Feb, 06:34 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-220

  17. Benni Mack voted on patch set 5 V +1 CR +1 02/20/20, 23:11

  18. Georg Ringer voted on patch set 5 V +2 CR +2 02/21/20, 06:29

  19. Georg Ringer merged patch set 6 02/21/20, 06:29

  20. Sybille Peters commented on patch set 6 02/21/20, 06:32

    arg!! I just noticed the text in the migration is wrong. Should be isLinkTargetBrokenLink() instead of "Use :php:`BrokenLinkRepository::getNumberOfBrokenLinks()` instead."
  21. Julian Hofmann commented on patch set 6 02/21/20, 15:15

    Instruction for migration makes no sense.

    Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:32 Unresolved

    Using the deprecated method instead of the deprecated method wouldn't change anything.
  22. Sybille Peters commented on patch set 6 02/21/20, 17:18

    Deprecation-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst:32 Unresolved

    Right. I noticed that around the time this got merged, see my previous comment. Will have to get fixed in another patch. Sorry about the mess :(