Review main Merged

63273[DOCS] Use correct event names in changelog

Sybille Peters CR +2 V +2 Easy +2 −2 updated 02/16/20, 19:35

Commit message

Events are named AfterSectionMarkupGeneratedEvent and
BeforeSectionMarkupGeneratedEvent.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Sybille Peters uploaded patch set 1 02/16/20, 14:34

  2. TYPO3com voted on patch set 1 V +1 02/16/20, 14:48 Completed build in 13m 21s on Sun, 16 Feb, 02:48 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-172

  3. Daniel Goerz commented on patch set 1 02/16/20, 15:20

    Feature-88921-NewEventInThePageLayoutViewClassToEnrichContentIntoTheColumnsInTheBackendLayout.rst:30

    I think the name PageLayoutViewDrawEmptyColposContent for the listener is fine because it is an implementation to render something into empty colPos sections. See \TYPO3\CMS\Backend\View\PageLayoutViewDrawEmptyColposContent in core.
  4. Sybille Peters commented on patch set 1 02/16/20, 15:41

    Feature-88921-NewEventInThePageLayoutViewClassToEnrichContentIntoTheColumnsInTheBackendLayout.rst:30 Reply

    Ok, thanks. I'll push another change to just leave it as is.
  5. Sybille Peters uploaded patch set 2 02/16/20, 15:44

  6. Sybille Peters commented on patch set 2 02/16/20, 15:44

    Feature-88921-NewEventInThePageLayoutViewClassToEnrichContentIntoTheColumnsInTheBackendLayout.rst:30 Reply

    Done
  7. Daniel Goerz voted on patch set 2 V +1 CR +1 02/16/20, 15:45

  8. TYPO3com voted on patch set 2 V +1 02/16/20, 15:57 Completed build in 13m 37s on Sun, 16 Feb, 03:57 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-176

  9. Björn Jacob voted on patch set 2 V +1 CR +1 02/16/20, 19:28

  10. Georg Ringer voted on patch set 2 V +2 CR +2 02/16/20, 19:35

  11. Georg Ringer merged patch set 3 02/16/20, 19:35