63275[TASK] Mark TypeConverterException final
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Stefan Froemken +1
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 89
-
Alexander Schnitzler uploaded patch set 1 02/17/20, 08:48
-
Mathias Brodala commented on patch set 1 02/17/20, 08:49
Another option would be adding a final constructor which would be less breaking. -
TYPO3com voted on patch set 1 V +1 02/17/20, 09:00 Completed build in 12m 49s on Mon, 17 Feb, 09:00 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-190
-
Alexander Schnitzler commented on patch set 1 02/17/20, 09:03
> Patch Set 1: > > Another option would be adding a final constructor which would be less breaking. I am open for different reasons, even simply ignoring this phpstan error for now. -
Stefan Froemken commented on patch set 1 CR +1 02/18/20, 21:15
final is absolutely OK for me. Hey...it's an Exception. If you want to extend it, extend it from extbase class directly, create a copy or create your own Exception class. No problem for me. -
Susi Moog voted on patch set 1 V +1 CR +1 02/22/20, 18:33
-
Daniel Goerz voted on patch set 1 V +2 CR +2 02/22/20, 19:53
-
Daniel Goerz merged patch set 2 02/22/20, 19:53
-
Daniel Goerz commented on patch set 2 02/22/20, 21:29
The phpstan error exclusion rule for this class can be removed now