63276[TASK] Ignore phpstan errors to achieve level 0 compatibility
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Mathias Brodala +1
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Susi Moog +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1315
-
Alexander Schnitzler uploaded patch set 1 02/17/20, 09:58
-
Alexander Schnitzler wrote 02/17/20, 09:59
Topic set to phpstan -
Mathias Brodala commented on patch set 1 02/17/20, 10:04
AbstractRecordCollection.php:345UnresolvedThis must be "final" instead, the constructor does not need to be private for this. -
Alexander Schnitzler uploaded patch set 2 02/17/20, 10:08
-
TYPO3com voted on patch set 1 V +1 02/17/20, 10:12 Completed build in 14m 33s on Mon, 17 Feb, 10:12 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-194
-
Mathias Brodala voted on patch set 2 CR +1 02/17/20, 10:13
-
TYPO3com voted on patch set 2 V +1 02/17/20, 10:27 Completed build in 16m 04s on Mon, 17 Feb, 10:27 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-196
-
Alexander Schnitzler commented on patch set 2 02/20/20, 09:18
ping -
Benni Mack voted on patch set 2 V +1 CR +1 02/20/20, 18:50
-
Susi Moog voted on patch set 2 CR +1 02/21/20, 13:47
-
Daniel Goerz commented on patch set 2 02/21/20, 13:53
I still get 1 error: ----- ---------------------------------------------------------------------------------- Line extbase/Classes/Property/TypeConverter/ObjectConverter.php ------ -------------------------------------------------------------------------------- 135 Method TYPO3\CMS\Extbase\Property\TypeConverter\ObjectConverter::getTypeOfChildProperty() should return string but return statement is missing. ------ -------------------------------------------------------------------------------- -
Daniel Goerz commented on patch set 2 02/21/20, 14:57
Alex will take care of the remaining error later -
Daniel Goerz voted on patch set 2 V +2 CR +2 02/21/20, 14:57
-
Susi Moog voted on patch set 2 V +1 02/21/20, 14:57
-
Daniel Goerz merged patch set 3 02/21/20, 14:57