Review main Merged

63277[TASK] Comment out bleeding edge phpstan configuration

Alexander Schnitzler CR +2 V +2 Easy +2 −1 updated 02/19/20, 08:52

Commit message

Bleeding edge configuration may be useful to use
but shouldn't be enabled by default. To make the
inclusion convenient, the include has only be
commented and not be removed at all.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Alexander Schnitzler uploaded patch set 1 02/17/20, 10:05

  2. Alexander Schnitzler wrote 02/17/20, 10:10

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 02/17/20, 10:20 Completed build in 14m 51s on Mon, 17 Feb, 10:20 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-195

  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/17/20, 12:11

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 02/19/20, 08:51

  6. Daniel Goerz merged patch set 2 02/19/20, 08:52