Review main Abandoned

63279[TASK] Unify info icons in Beuser module

Georg Ringer CR 0 V 0 Easy +2 −3 updated 03/18/20, 08:05

Commit message

Since #90298 there are 2 info icons, one for triggering the
ElementInformationController and one for the extended detail view.

The first one can be removed because the it only contains very basic
information and only the extended detail view contains information from
assigned usergroupd because the it only contains very basic information
and only the extended detail view contains information from assigned
usergroups.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 79

  1. Georg Ringer uploaded patch set 1 02/17/20, 15:33

  2. Georg Ringer commented on patch set 1 02/17/20, 15:33

    This change is ready for review.
  3. Daniel Goerz voted on patch set 1 V +1 CR +1 02/17/20, 15:42

  4. TYPO3com voted on patch set 1 V +1 02/17/20, 15:48 Completed build in 15m 41s on Mon, 17 Feb, 03:48 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-212

  5. Markus Klein commented on patch set 1 CR -1 02/17/20, 16:41

    Why can the first one be removed? Please put that information into the commit message or at least in the ticket.
  6. Georg Ringer uploaded patch set 2 02/17/20, 18:11

  7. TYPO3com voted on patch set 2 V -1 02/17/20, 18:27 Completed build in 15m 17s on Mon, 17 Feb, 06:27 PM Test Summary: 67621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-218

  8. Stefan Froemken commented on patch set 2 V +1 CR -1 02/17/20, 21:24

    Unresolved

    Remove "the"

    Unresolved

    duplicated

    IndexListRow.html:77 Unresolved

    This JS will be filled by the JS of TYPO3.settings "ShowItem" with the URI generated in PHP with getModulePath(). Can we please remove all these cross references, too?
  9. Georg Ringer abandoned the change 03/18/20, 08:05