63288[TASK] Improve dependency injection container caching
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Core/Bootstrap.php+10 −2
- typo3/sysext/core/Classes/DependencyInjection/Cache/ContainerBackend.phpnew+36 −0
- typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php+17 −24
- typo3/sysext/core/Classes/Package/PackageManager.php+3 −2
- typo3/sysext/core/Classes/ServiceProvider.php+2 −0
- typo3/sysext/install/Classes/Service/ClearCacheService.php+37 −28
- typo3/sysext/install/Classes/Service/LateBootService.php+2 −5
Review log 1520
-
Helmut Hummel uploaded patch set 1 02/18/20, 13:22
-
TYPO3com voted on patch set 1 V +1 02/18/20, 13:35 Completed build in 13m 45s on Tue, 18 Feb, 01:35 PM Test Summary: 71342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-242
-
Helmut Hummel updated the commit message in patch set 2 02/18/20, 14:06
-
TYPO3com voted on patch set 2 V +1 02/18/20, 14:24 Completed build in 15m 57s on Tue, 18 Feb, 02:24 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-247
-
Benni Mack commented on patch set 2 V +1 CR +1 02/18/20, 22:35
works great. -
Daniel Goerz commented on patch set 2 V -1 02/19/20, 08:25
When clearing caches through install tool, I encounter a PHP warning now: PHP Warning: file_put_contents([...]/var/cache/code/di/5e4cf08cc9184312977939.temp): failed to open stream: No such file or directory in [...]/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php line 228 -
Susi Moog commented on patch set 2 V -1 02/19/20, 09:07
Same here, Backend UI works fine, install tool ends up in a 500, same error as Daniel. -
Benni Mack commented on patch set 2 02/19/20, 22:00
works for me on the first time, but triggering it back again from the backend throws an error. -
Benni Mack commented on patch set 2 02/20/20, 13:21
@helhum could you take care of the issue please? -
Helmut Hummel uploaded patch set 3 02/20/20, 13:48
-
TYPO3com voted on patch set 3 V +1 02/20/20, 14:25 Completed build in 25m 04s on Thu, 20 Feb, 02:25 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-342
-
Helmut Hummel uploaded patch set 4 02/20/20, 15:20
-
Helmut Hummel commented on patch set 4 02/20/20, 15:21
Fatal errors are fixed now. I changed the way the install tool flushes caches to not bypass the API any more, plus some extra code to also flush DI cache (for now) -
TYPO3com voted on patch set 4 V -1 02/20/20, 15:23 Completed build in 40s on Thu, 20 Feb, 03:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-348
-
Daniel Goerz commented on patch set 5 02/20/20, 16:04
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 02/20/20, 17:42 Completed build in 19m 19s on Thu, 20 Feb, 05:42 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-352
-
Benni Mack commented on patch set 5 02/20/20, 18:46
works now on multiple tests. -
Georg Ringer voted on patch set 5 V +1 CR +1 02/20/20, 19:05
-
Benni Mack voted on patch set 5 V +2 CR +2 02/20/20, 21:44
-
Benni Mack merged patch set 6 02/20/20, 21:44