Review main Merged

63288[TASK] Improve dependency injection container caching

Helmut Hummel CR +2 V +2 Normal +107 −61 updated 02/20/20, 21:44

Commit message

Disallow disabling and flushing the DI cache and
base the cache identifier as well on the currently
installed extensions.

A disabled DI cache creates an unbearable performance hit,
so that disabling won't make sense anyway.
Disallowing flushing that cache will not flush the DI cache
when caches are flushed using the regular backend UI,
but only when caches in install tool are flushed.

Last but not least, the install tool cache flushing is
changed to not bypass the caching API any more by removing complete
caching folders or caching database tables.
Instead the CacheManager is now used twice, once with basic
caching configuration and a second time with caching configuration
that is provided by extensions (if any).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1520

  1. Helmut Hummel uploaded patch set 1 02/18/20, 13:22

  2. TYPO3com voted on patch set 1 V +1 02/18/20, 13:35 Completed build in 13m 45s on Tue, 18 Feb, 01:35 PM Test Summary: 71342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-242

  3. Helmut Hummel updated the commit message in patch set 2 02/18/20, 14:06

  4. TYPO3com voted on patch set 2 V +1 02/18/20, 14:24 Completed build in 15m 57s on Tue, 18 Feb, 02:24 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-247

  5. Benni Mack commented on patch set 2 V +1 CR +1 02/18/20, 22:35

    works great.
  6. Daniel Goerz commented on patch set 2 V -1 02/19/20, 08:25

    When clearing caches through install tool, I encounter a PHP warning now: PHP Warning: file_put_contents([...]/var/cache/code/di/5e4cf08cc9184312977939.temp): failed to open stream: No such file or directory in [...]/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php line 228
  7. Susi Moog commented on patch set 2 V -1 02/19/20, 09:07

    Same here, Backend UI works fine, install tool ends up in a 500, same error as Daniel.
  8. Benni Mack commented on patch set 2 02/19/20, 22:00

    works for me on the first time, but triggering it back again from the backend throws an error.
  9. Benni Mack commented on patch set 2 02/20/20, 13:21

    @helhum could you take care of the issue please?
  10. Helmut Hummel uploaded patch set 3 02/20/20, 13:48

  11. TYPO3com voted on patch set 3 V +1 02/20/20, 14:25 Completed build in 25m 04s on Thu, 20 Feb, 02:25 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-342

  12. Helmut Hummel uploaded patch set 4 02/20/20, 15:20

  13. Helmut Hummel commented on patch set 4 02/20/20, 15:21

    Fatal errors are fixed now. I changed the way the install tool flushes caches to not bypass the API any more, plus some extra code to also flush DI cache (for now)
  14. TYPO3com voted on patch set 4 V -1 02/20/20, 15:23 Completed build in 40s on Thu, 20 Feb, 03:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-348

  15. Daniel Goerz commented on patch set 5 02/20/20, 16:04

    Published edit on patch set 4.
  16. TYPO3com voted on patch set 5 V +1 02/20/20, 17:42 Completed build in 19m 19s on Thu, 20 Feb, 05:42 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-352

  17. Benni Mack commented on patch set 5 02/20/20, 18:46

    works now on multiple tests.
  18. Georg Ringer voted on patch set 5 V +1 CR +1 02/20/20, 19:05

  19. Benni Mack voted on patch set 5 V +2 CR +2 02/20/20, 21:44

  20. Benni Mack merged patch set 6 02/20/20, 21:44