Review main Merged

63289[FEATURE] Define target file extension in Image-related ViewHelpers

Benni Mack CR +2 V +2 Normal +79 −3 updated 02/18/20, 19:41

Commit message

When rendering custom formats with the <source> tag (as an example),
it currently is not possible to specificy a target file extension (e.g. webp
as alternative).

A new argument "fileExtension" for the <f:image>, <f:media> and
<f:uri.media> is introduced to specify a custom output format for having
variants on image variants.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Benni Mack uploaded patch set 1 02/18/20, 13:33

  2. TYPO3com voted on patch set 1 V +1 02/18/20, 13:49 Completed build in 14m 50s on Tue, 18 Feb, 01:49 PM Test Summary: 71349 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-244

  3. Benni Mack commented on patch set 2 02/18/20, 14:33

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 02/18/20, 14:47 Completed build in 14m 02s on Tue, 18 Feb, 02:47 PM Test Summary: 71350 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-250

  5. Georg Ringer voted on patch set 2 V +1 CR +1 02/18/20, 18:27

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/18/20, 19:41

  7. Anja Leichsenring merged patch set 3 02/18/20, 19:41