Review main Merged

63290[TASK] Deprecate DocumentTemplate

Benni Mack CR +2 V +2 Normal +84 −70 updated 02/20/20, 10:18

Commit message

Since TYPO3 v7, the new ModuleTemplate API is in place,
which contains a fluid-based and fluent interface possibility
to add DocHeader components and to render content.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 710

  1. Benni Mack uploaded patch set 1 02/18/20, 15:01

  2. TYPO3com voted on patch set 1 V +1 02/18/20, 15:15 Completed build in 13m 14s on Tue, 18 Feb, 03:15 PM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-253

  3. Georg Ringer uploaded patch set 2 02/18/20, 18:26

  4. Georg Ringer voted on patch set 2 V +1 CR +1 02/18/20, 18:26

  5. TYPO3com voted on patch set 2 V -1 02/18/20, 18:40 Completed build in 13m 23s on Tue, 18 Feb, 06:40 PM Test Summary: 71050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-256

  6. TYPO3com voted on patch set 2 V +1 02/18/20, 19:08 Completed build in 55m 32s on Tue, 18 Feb, 07:08 PM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-256

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/18/20, 20:04

  8. Anja Leichsenring merged patch set 3 02/18/20, 20:04

  9. Alexander Schnitzler commented on patch set 3 02/20/20, 09:15

    DocumentTemplate.php:231 Unresolved

    Post -1 > ------ ----------------------------------------------- > Line backend/Classes/Template/DocumentTemplate.php > ------ ----------------------------------------------- > 231 Function trigerr_error not found. > ------ -----------------------------------------------
  10. Benni Mack commented on patch set 3 02/20/20, 10:18

    Cool. Thanks Alex. Will take care