Review main Merged

63291[BUGFIX] Make $actionName argument in ExtensionService nullable

Christian Eßl CR +2 V +2 Easy +3 −3 updated 03/03/20, 09:09

Commit message

The method ExtensionService::getPluginNameByAction() was hardened in
This breaks previous functionality, where it was possible to call
ActionController::redirect() without an action given, which produces
perfectly valid urls.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Oli Bartsch +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1417

  1. Christian Eßl uploaded patch set 1 02/18/20, 17:13

  2. Christian Eßl commented on patch set 1 02/18/20, 17:16

    Hi, what is your opinion on this bug? Should we: - Preserve the original behaviour (like done in this commit) - Or change the ActionController::redirect() method to always require giving it an action name. (This would have to be checked inside the method and handled with an exception, as the "action" arguments can either be given as $actionName or in the $arguments array). This would then also have to be marked as breaking change.
  3. TYPO3com voted on patch set 1 V -1 02/18/20, 17:28 Completed build in 14m 10s on Tue, 18 Feb, 05:28 PM Test Summary: 71325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-255

  4. TYPO3com voted on patch set 1 V +1 02/18/20, 18:54 Completed build in 14m 58s on Tue, 18 Feb, 06:54 PM Test Summary: 71338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-258

  5. Alexander Schnitzler wrote 02/19/20, 06:17

    Topic set to extbase
  6. Alexander Schnitzler commented on patch set 1 02/19/20, 07:36

    At first glance it looks wrong making the action optional again due to the naming of said method but I am fine with loosening the type for now. I will look into it later but that's my first idea about this issue.
  7. Benni Mack voted on patch set 1 CR +1 03/02/20, 21:41

  8. Georg Ringer voted on patch set 1 V +1 CR +1 03/03/20, 00:35

  9. Oli Bartsch voted on patch set 1 CR +1 03/03/20, 07:52

  10. Alexander Schnitzler commented on patch set 1 CR -1 03/03/20, 08:22

    This needs more adjustments.
  11. Alexander Schnitzler uploaded patch set 2 03/03/20, 08:24

  12. TYPO3com voted on patch set 2 V +1 03/03/20, 08:34 Completed build in 10m 20s on Tue, 3 Mar, 08:34 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-935

  13. Alexander Schnitzler voted on patch set 2 V +1 CR +1 03/03/20, 08:43

  14. Christian Eßl voted on patch set 2 CR +1 03/03/20, 08:47

  15. Oli Bartsch voted on patch set 2 CR +1 03/03/20, 08:50

  16. Alexander Schnitzler voted on patch set 2 V +2 CR +2 03/03/20, 09:08

  17. Alexander Schnitzler merged patch set 3 03/03/20, 09:09