Review 9.5 Merged

63292[BUGFIX] Use single instance of DocumentTypeExclusionRestriction

Richard Haeser CR +2 V +2 Normal +82 −11 updated 02/17/20, 22:14

Commit message

With this change, the DocumentTypeExclusionRestrictionTest will use
NOT IN instead of <>. This will allow to have only one instance of that
restriction.

Additionally multiple casts to integer have been removed.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Richard Haeser commented on patch set 1 02/17/20, 21:43

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Database/Query/Restriction/DocumentTypeExclusionRestriction.php
  2. TYPO3com voted on patch set 1 V -1 02/17/20, 21:44 Completed build in 37s on Mon, 17 Feb, 09:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-42

  3. Richard Haeser uploaded patch set 2 02/17/20, 21:48

  4. Richard Haeser commented on patch set 2 02/17/20, 21:48

    This change is ready for review.
  5. Richard Haeser voted on patch set 2 V +1 CR +1 02/17/20, 21:56

  6. TYPO3com voted on patch set 2 V +1 02/17/20, 22:13 Completed build in 19m 53s on Mon, 17 Feb, 10:13 PM Test Summary: 74345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-43

  7. Richard Haeser voted on patch set 2 V +2 CR +2 02/17/20, 22:14

  8. Richard Haeser merged patch set 3 02/17/20, 22:14