Review TYPO3_8-7 Merged

63307[BUGFIX] Prevent separating HTML inline elements

Susi Moog CR +2 V +2 Easy +1 −1 updated 02/23/20, 10:30

Commit message

The softhyphen button in RTE CKEditor separates HTML inline elements.
If the softhyphen is inserted inside a link, it results in two
individual links with the ­ entity between.

This can already be examined in the source view of the RTE.

Furthermore, a ­ entity between two HTML tags will prevent the
browser to insert a hyphen at the position of the linebreak.

Setting the optional mode 'text' to the insertHtml event will prevent
this behaviour, as the inserted content will then inherit the styles
which are applied in the selected position.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Susi Moog commented on patch set 1 02/22/20, 18:11

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V +1 02/22/20, 18:31 Completed build in 16m 03s on Sat, 22 Feb, 06:31 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-19

  3. Susi Moog voted on patch set 1 V +2 CR +2 02/23/20, 10:30

  4. Susi Moog merged patch set 2 02/23/20, 10:30