Review main Merged

63308Revert "[FEATURE] Allow PageContentErrorHandler to resolve pages with sub requests"

Susi Moog CR +2 V +2 Normal +41 −89 updated 02/24/20, 20:15

Commit message

This reverts commit a848ba4f2798105d86537ae7b1185f661d29bd3d.

While the feature works well on fully configured sites, in case of errors this is
currently too unstable and may result in infinite recursions when a page is not
configured (for example if no TS Template is present).

When reimplementing we should add more tests and recursion prevention in order to
stabilize the behaviour.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Susi Moog uploaded patch set 1 02/24/20, 18:19

  2. Susi Moog updated the commit message in patch set 2 02/24/20, 18:22

  3. Susi Moog updated the commit message in patch set 3 02/24/20, 18:22

  4. Georg Ringer voted on patch set 3 V +1 CR +1 02/24/20, 18:24

  5. TYPO3com voted on patch set 1 V +1 02/24/20, 18:32 Completed build in 13m 30s on Mon, 24 Feb, 06:32 PM Test Summary: 71649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-641

  6. TYPO3com voted on patch set 2 V +1 02/24/20, 18:40 Completed build in 15m 54s on Mon, 24 Feb, 06:40 PM Test Summary: 71649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-642

  7. TYPO3com voted on patch set 3 V +1 02/24/20, 18:46 Completed build in 22m 21s on Mon, 24 Feb, 06:46 PM Test Summary: 71649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-643

  8. Georg Ringer voted on patch set 3 V +2 CR +2 02/24/20, 18:51

  9. Georg Ringer merged patch set 4 02/24/20, 18:51

  10. Anja Leichsenring commented on patch set 4 02/24/20, 20:15