Review main Merged

63316[TASK] Improve check if records exist in DatabaseRecordList

Georg Ringer CR +2 V +2 Easy +1 −0 updated 02/20/20, 07:39

Commit message

Limit the query to 1 row to check if there are records available
which improves the performance.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Stefan Froemken +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Stefan Froemken +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Georg Ringer uploaded patch set 1 02/18/20, 20:11

  2. Georg Ringer commented on patch set 1 02/18/20, 20:21

    This change is ready for review.
  3. Stefan Froemken voted on patch set 1 CR -1 02/18/20, 20:30

  4. Stefan Froemken commented on patch set 1 02/18/20, 20:34

    Please don't merge that. I was involved into this problem years ago. I found out that InnoDB don't know the exact amount records in DB table. That's why a little FTS was started which loops over each index entry to count the records. MyISAM instead always knows the amount of records. To show a table or not I have created the patch to only fetch the first record, which is much faster than counting 250.000 of records.
  5. TYPO3com voted on patch set 1 V +1 02/18/20, 20:42 Completed build in 29m 36s on Tue, 18 Feb, 08:42 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-273

  6. Benni Mack commented on patch set 1 02/18/20, 21:27

    > Patch Set 1: > > Please don't merge that. I was involved into this problem years ago. I found out that InnoDB don't know the exact amount records in DB table. That's why a little FTS was started which loops over each index entry to count the records. MyISAM instead always knows the amount of records. To show a table or not I have created the patch to only fetch the first record, which is much faster than counting 250.000 of records. VERY interesting - I think we should use this change to document the existing behaviour in the code, and explain the reasoning behind it. What do you think, Georg?
  7. Georg Ringer uploaded patch set 2 02/19/20, 04:50

  8. TYPO3com voted on patch set 2 V +1 02/19/20, 05:03 Completed build in 12m 53s on Wed, 19 Feb, 05:03 AM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-286

  9. Stefan Froemken voted on patch set 2 V +1 CR +1 02/19/20, 06:20

  10. Daniel Goerz voted on patch set 2 CR +1 02/19/20, 08:12

  11. Christian Eßl voted on patch set 2 V +1 CR +1 02/20/20, 06:28

  12. Oli Bartsch voted on patch set 2 CR +1 02/20/20, 06:56

  13. Daniel Goerz voted on patch set 2 V +2 CR +2 02/20/20, 07:39

  14. Daniel Goerz merged patch set 3 02/20/20, 07:39