63317[FEATURE] Add native browser lazy loading for images
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Christian Eßl +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Christian Eßl +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Feature-90426-Browser-nativeLazyLoadingForImages.rstnew+39 −0
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php2+1 −0
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php2+4 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.typoscript+1 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/constants.typoscript+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Partials/Media/Rendering/Image.html+1 −1
Review log 1319
-
Benni Mack uploaded patch set 1 02/18/20, 21:51
-
Benni Mack uploaded patch set 2 02/18/20, 21:56
-
Benni Mack updated the commit message in patch set 3 02/18/20, 21:58
-
TYPO3com voted on patch set 1 V +1 02/18/20, 22:11 Completed build in 17m 04s on Tue, 18 Feb, 10:11 PM Test Summary: 71343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-275
-
TYPO3com voted on patch set 2 V -1 02/18/20, 22:18 Completed build in 16m 23s on Tue, 18 Feb, 10:18 PM Test Summary: 1 of 71800 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-276
-
TYPO3com voted on patch set 3 V +1 02/18/20, 22:24 Completed build in 22m 33s on Tue, 18 Feb, 10:24 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-277
-
Benni Mack uploaded patch set 4 02/18/20, 22:47
-
Kevin Appelt commented on patch set 4 02/18/20, 23:07
Great feature - just two little questions.ImageViewHelper.php:117Do we want/need to set a default here?MediaViewHelper.php:161Should we check if it is any of the three allowed (auto, lazy or eager) values? -
TYPO3com voted on patch set 4 V +1 02/18/20, 23:19 Completed build in 16m 51s on Tue, 18 Feb, 11:19 PM Test Summary: 71343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-283
-
Georg Ringer commented on patch set 4 CR -1 02/19/20, 04:10
We should rename all occurrences of image with media as it can also be used for iframes. -
Benni Mack commented on patch set 4 02/19/20, 08:37
> Patch Set 4: Code-Review-1 > > We should rename all occurrences of image with media as it can also be used for iframes. I did this in the beginning but then figured out that TYPO3 Core has *no* built-in way to add this to iframes at all. We don't have a CType "iframe" or such. We also don't ship "img" in the RTE which is why I didn't modify lib.parseFunc. This would all be up for the authors to use "iframe" to either use a different custom / default value.ImageViewHelper.php:117Reply Unresolveddefault is "null" = autoloading is not rendered, only if you explicitly set this option. If you e.g. build custom content elements for a slider, it should be up to the integrator to decide the lazy loading, and defined as "lazy" by default. Setting a default value here would also modify all occurrences in the TYPO3 Backend to use "loading=lazy" (or any other default) to be set, even though this might not make sense in that use caseMediaViewHelper.php:161Reply Unresolvedyeah, makes sense -
Georg Ringer voted on patch set 4 V +1 CR +1 02/19/20, 13:12
-
Benni Mack commented on patch set 5 02/19/20, 21:58
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V -1 02/19/20, 22:12 Completed build in 13m 28s on Wed, 19 Feb, 10:12 PM Test Summary: 71463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-330
-
Georg Ringer voted on patch set 5 V +1 CR +1 02/20/20, 05:00
-
Christian Eßl voted on patch set 5 V +1 CR +1 02/20/20, 06:28
-
TYPO3com voted on patch set 5 V +1 02/20/20, 13:40 Completed build in 11h 50m 57s on Thu, 20 Feb, 01:40 PM Test Summary: 71463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-330
-
Benni Mack voted on patch set 5 V +2 CR +2 02/20/20, 14:02
-
Benni Mack merged patch set 6 02/20/20, 14:02