Review main Merged

63321[DOCS] Add directive to deny access for current Apache

Chris Müller CR +2 V +2 Easy +14 −5 updated 02/19/20, 19:39

Commit message

The example in the note shows how to deny access up to Apache 2.2.
The directive for the current version is added.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Chris Müller uploaded patch set 1 02/19/20, 13:38

  2. Chris Müller uploaded patch set 2 02/19/20, 13:45

  3. TYPO3com voted on patch set 1 V +1 02/19/20, 13:52 Completed build in 14m 25s on Wed, 19 Feb, 01:52 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-302

  4. TYPO3com voted on patch set 2 V +1 02/19/20, 14:06 Completed build in 16m 12s on Wed, 19 Feb, 02:06 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-304

  5. Mathias Brodala commented on patch set 2 02/19/20, 14:30

    Index.rst:57

    This should be the first example and the older version follow after that. We could also mention mod_access_compat here which enables the old syntax for newer Apache versions.
  6. Markus Klein commented on patch set 2 02/19/20, 14:51

    Index.rst:57 Reply

    ``` # Apache ≥ 2.3 <IfModule mod_authz_core.c> Require all denied </IfModule> # Apache < 2.3 <IfModule !mod_authz_core.c> Order allow,deny Deny from all Satisfy All </IfModule> ``` IfModule is necessary to avoid breaking things on servers where access_compat is not there, etc.
  7. Mathias Brodala commented on patch set 2 02/19/20, 14:53

    Index.rst:57 Reply

    That's correct but usually you run your project on a known, single Apache version and don't switch between versions all the time. So only having one variant depending on the Apache version in your .htaccess makes sense IMO.
  8. Markus Klein commented on patch set 2 02/19/20, 15:06

    Index.rst:57 Reply

    If you use this as a copy&paste template it might be helpful, but of course this is not a hard requirement.
  9. Björn Jacob commented on patch set 2 02/19/20, 17:57

    Index.rst:57 Reply Unresolved

    Since we are having those checks in the "main" .htaccess as well, I would opt for using the variant of Markus.
  10. Chris Müller uploaded patch set 3 02/19/20, 18:42

  11. TYPO3com voted on patch set 3 V +1 02/19/20, 18:55 Completed build in 12m 58s on Wed, 19 Feb, 06:55 PM Test Summary: 71462 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-321

  12. Björn Jacob commented on patch set 3 V +1 CR +1 02/19/20, 19:37

    Awesome. Thanks for your contribution.
  13. Ralf Zimmermann voted on patch set 3 V +2 CR +2 02/19/20, 19:39

  14. Ralf Zimmermann merged patch set 4 02/19/20, 19:39