63321[DOCS] Add directive to deny access for current Apache
Commit message
Review
-
Code review CR +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
-
Verified V +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1114
-
Chris Müller uploaded patch set 1 02/19/20, 13:38
-
Chris Müller uploaded patch set 2 02/19/20, 13:45
-
TYPO3com voted on patch set 1 V +1 02/19/20, 13:52 Completed build in 14m 25s on Wed, 19 Feb, 01:52 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-302
-
TYPO3com voted on patch set 2 V +1 02/19/20, 14:06 Completed build in 16m 12s on Wed, 19 Feb, 02:06 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-304
-
Mathias Brodala commented on patch set 2 02/19/20, 14:30
-
Markus Klein commented on patch set 2 02/19/20, 14:51
Index.rst:57Reply``` # Apache ≥ 2.3 <IfModule mod_authz_core.c> Require all denied </IfModule> # Apache < 2.3 <IfModule !mod_authz_core.c> Order allow,deny Deny from all Satisfy All </IfModule> ``` IfModule is necessary to avoid breaking things on servers where access_compat is not there, etc. -
Mathias Brodala commented on patch set 2 02/19/20, 14:53
Index.rst:57ReplyThat's correct but usually you run your project on a known, single Apache version and don't switch between versions all the time. So only having one variant depending on the Apache version in your .htaccess makes sense IMO. -
Markus Klein commented on patch set 2 02/19/20, 15:06
Index.rst:57ReplyIf you use this as a copy&paste template it might be helpful, but of course this is not a hard requirement. -
Björn Jacob commented on patch set 2 02/19/20, 17:57
Index.rst:57Reply UnresolvedSince we are having those checks in the "main" .htaccess as well, I would opt for using the variant of Markus. -
Chris Müller uploaded patch set 3 02/19/20, 18:42
-
TYPO3com voted on patch set 3 V +1 02/19/20, 18:55 Completed build in 12m 58s on Wed, 19 Feb, 06:55 PM Test Summary: 71462 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-321
-
Björn Jacob commented on patch set 3 V +1 CR +1 02/19/20, 19:37
Awesome. Thanks for your contribution. -
Ralf Zimmermann voted on patch set 3 V +2 CR +2 02/19/20, 19:39
-
Ralf Zimmermann merged patch set 4 02/19/20, 19:39
Index.rst:57