Review main Merged

63322[BUGFIX] Calculate correct cache identifier for cached SQL statement

Markus Klein CR +2 V +2 Easy +4 −3 updated 02/20/20, 23:04

Commit message

BackendUtility::getPageForRootline() must use a more specific
cache identifier for the SQL statement in order to deliver correct
data.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wolfgang Klinger +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wolfgang Klinger +1
    • Christian Eßl +1

Issues 1

Files 1

Review log 1012

  1. Markus Klein uploaded patch set 1 02/19/20, 15:18

  2. TYPO3com voted on patch set 1 V -1 02/19/20, 15:32 Completed build in 13m 48s on Wed, 19 Feb, 03:32 PM Test Summary: 105 of 71800 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-313

  3. Georg Ringer voted on patch set 1 V +1 CR +1 02/19/20, 18:57

  4. Markus Klein uploaded patch set 2 02/19/20, 19:07

  5. TYPO3com voted on patch set 2 V +1 02/19/20, 19:21 Completed build in 13m 35s on Wed, 19 Feb, 07:21 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-322

  6. Christian Eßl voted on patch set 2 V +1 CR +1 02/19/20, 19:23

  7. Wolfgang Klinger commented on patch set 2 CR -1 02/19/20, 19:28

    The set call has to be adapted as well: $runtimeCache->set('getPageForRootlineStatement-' . $statementCacheIdent), $statement);
  8. Markus Klein commented on patch set 3 02/20/20, 07:55

    Published edit on patch set 2.
  9. Wolfgang Klinger commented on patch set 3 V +1 CR +1 02/20/20, 08:01

    Verified, thanks a lot!
  10. Christian Eßl voted on patch set 3 V +1 CR +1 02/20/20, 09:33

  11. Benni Mack voted on patch set 3 V +2 CR +2 02/20/20, 23:04

  12. Benni Mack merged patch set 4 02/20/20, 23:04