Review main Abandoned

63325[TASK] Contrast ratio of text in active dashboard tab

Koen Wouters CR 0 V 0 Easy +2 −3 updated 02/19/20, 20:16

Commit message

Updated text color of active dashboard tab to black so the
contrast ratio of the text on the orange background is WCAG AA proof.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 68

  1. Koen Wouters uploaded patch set 1 02/19/20, 19:09

  2. Georg Ringer commented on patch set 1 CR -1 02/19/20, 19:26

    that is not a feature
  3. Koen Wouters updated the commit message in patch set 2 02/19/20, 19:28

  4. TYPO3com voted on patch set 1 V +1 02/19/20, 19:29 Completed build in 16m 40s on Wed, 19 Feb, 07:29 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-323

  5. TYPO3com voted on patch set 2 V -1 02/19/20, 19:42 Completed build in 14m 14s on Wed, 19 Feb, 07:42 PM Test Summary: 69147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-324

  6. Benjamin Kott voted on patch set 2 CR -1 02/19/20, 19:57

  7. Benjamin Kott commented on patch set 2 02/19/20, 19:58

    css not minified and see note about brand color

    _dashboard.scss:58 Unresolved

    we never match the brand color with a dark text color. the only thing we can do here is to not use the brand color and go for a dark highlight.
  8. Koen Wouters abandoned the change 02/19/20, 20:16

    Black on orange is not valid with the corporate identity.