63327[FEATURE] Introduce AssetCollector
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Georg Ringer +1
- Daniel Gohlke +1
- Kevin Appelt +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Georg Ringer +1
- Daniel Gohlke +1
- Kevin Appelt +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+11 −11
- typo3/sysext/core/Classes/Page/AssetCollector.php4new+186 −0
- typo3/sysext/core/Classes/Page/AssetRenderer.php3new+93 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+11 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-90522-TSFEPropertiesRegardingImages.rstnew+35 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-90522-IntroduceAssetCollector.rst2new+80 −0
- typo3/sysext/core/Tests/Unit/Page/AssetCollectorTest.phpnew+158 −0
- typo3/sysext/core/Tests/Unit/Page/AssetDataProvider.phpnew+403 −0
- typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.phpnew+92 −0
- typo3/sysext/extbase/Classes/Service/ImageService.php+9 −3
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+4 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php5new+101 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php3new+97 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+5 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php1+17 −2
Review log 5266
Show 3241 earlier messages
-
Benni Mack uploaded patch set 1 02/19/20, 22:15
-
TYPO3com voted on patch set 1 V -1 02/19/20, 22:28 Completed build in 13m 07s on Wed, 19 Feb, 10:28 PM Test Summary: 6 of 71920 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-331
-
Frank Nägler commented on patch set 1 CR -1 02/21/20, 09:23
on it -
Frank Nägler uploaded patch set 2 02/21/20, 13:52
-
Frank Nägler commented on patch set 2 CR -1 02/21/20, 13:54
still on it -
TYPO3com voted on patch set 2 V -1 02/21/20, 14:00 Completed build in 33s on Fri, 21 Feb, 02:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-402
-
Frank Nägler uploaded patch set 3 02/21/20, 14:03
-
Frank Nägler voted on patch set 3 CR -1 02/21/20, 14:03
-
Frank Nägler voted on patch set 3 CR 0 02/21/20, 14:15
-
TYPO3com voted on patch set 3 V -1 02/21/20, 14:39 Completed build in 18m 57s on Fri, 21 Feb, 02:39 PM Test Summary: 6 of 72316 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-403
-
Frank Nägler uploaded patch set 4 02/24/20, 17:12
-
TYPO3com voted on patch set 4 V -1 02/24/20, 17:12 Completed build in 29s on Mon, 24 Feb, 05:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-637
-
Frank Nägler uploaded patch set 5 02/24/20, 17:18
-
TYPO3com voted on patch set 5 V -1 02/24/20, 17:35 Completed build in 16m 14s on Mon, 24 Feb, 05:35 PM Test Summary: 6 of 72529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-639
-
Susi Moog uploaded patch set 6 02/24/20, 18:23
-
Kevin Appelt commented on patch set 6 02/24/20, 18:31
Is there a way to define the order of inclusion/loading? Like „load this slider lib before my slider script“ or alike? -
Frank Nägler commented on patch set 6 02/24/20, 18:33
> Is there a way to define the order of inclusion/loading? Like „load this slider lib before my slider script“ or alike? Not yet, and will also not be part of this patch. But ordering service will be the next step in this area. -
TYPO3com voted on patch set 6 V +1 02/24/20, 18:52 Completed build in 28m 18s on Mon, 24 Feb, 06:52 PM Test Summary: 72045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-644
-
Frank Nägler uploaded patch set 7 02/24/20, 18:57
-
TYPO3com voted on patch set 7 V -1 02/24/20, 19:10 Completed build in 13m 06s on Mon, 24 Feb, 07:10 PM Test Summary: 71881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-647
-
TYPO3com voted on patch set 7 V +1 02/24/20, 19:39 Completed build in 55m 16s on Mon, 24 Feb, 07:39 PM Test Summary: 71991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-647
-
Andreas Kienast commented on patch set 7 CR -1 02/24/20, 20:02
on itAssetCollector.php:173UnresolvedI'd rename this method to "getInlineJavaScripts()" (everything else is in plural as well) -
Andreas Kienast commented on patch set 7 02/24/20, 20:05
TypoScriptFrontendController.php:544UnresolvedWill do a proper deprecation here. -
Kevin Appelt commented on patch set 7 02/24/20, 20:13
CssViewHelper.php:61Whats the reason to use hreflang for a stylesheet? Never have seen it before. -
Susi Moog commented on patch set 7 02/24/20, 20:15
CssViewHelper.php:61Replyadherence to the specification of the link tag I guess (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link) -
Frank Nägler commented on patch set 7 02/24/20, 20:18
CssViewHelper.php:61ReplyI guess this is the reason, I thought also about it, but decided to keep it, because it is valid for the <link> tag. -
Nikita Hovratov commented on patch set 7 02/24/20, 20:20
Feature-90522-IntroduceAssetCollectortAndAssetRenderer.rst:55In this example the rel="stylesheet" attribute is missing. Or can we have this as default, if a file is supplied? -
Kevin Appelt commented on patch set 7 02/24/20, 20:23
CssViewHelper.php:61Reply Unresolved"This attribute (hreflang) indicates the language of the linked resource." So yes, it is valid for the link attribute, but I guess it has no meaning at all for css files. Since this is the CssViewHelper and not the LinkViewHelper, I might consider removing it - especially to avoid misuse of this viewhelper to set the hreflang. -
Frank Nägler commented on patch set 7 02/24/20, 20:24
Feature-90522-IntroduceAssetCollectortAndAssetRenderer.rst:55ReplyGood point, but I would like to add this to the AssetRenderer not the VH -
David Steeb voted on patch set 7 CR +1 02/24/20, 20:40
-
Andreas Kienast uploaded patch set 8 02/24/20, 20:40
-
Frank Nägler commented on patch set 7 02/24/20, 20:40
Feature-90522-IntroduceAssetCollectortAndAssetRenderer.rst:55Reply Unresolvedwill push an update with defaults in the AssetRenderer class, after Andy has pushed. -
Frank Nägler uploaded patch set 9 02/24/20, 20:41
-
Nikita Hovratov commented on patch set 9 02/24/20, 20:45
AssetRenderer.php:39We can omit the text/javascript type attribute if we have html5 See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61300 -
Nikita Hovratov commented on patch set 9 02/24/20, 20:48
AssetRenderer.php:39Reply*As well as text/css -
Frank Nägler commented on patch set 9 02/24/20, 20:49
AssetRenderer.php:39Reply UnresolvedAgree, but the context is not clear at this moment. I would keep it, for now, because the patch must go in until tomorrow. I am fine to change this or find a solution for the 10.4 release. -
TYPO3com voted on patch set 8 V -1 02/24/20, 20:56 Completed build in 16m 12s on Mon, 24 Feb, 08:56 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-652
-
Nikita Hovratov commented on patch set 9 02/24/20, 21:01
ScriptViewHelper.php:29should be src instead of href in the example -
Nikita Hovratov commented on patch set 9 02/24/20, 21:07
> Patch Set 8: Verified-1 > > Completed build in 16m 12s on Mon, 24 Feb, 08:56 PM > Test Summary: 71997 passed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-652 Keywords are missing in the Deprecation rst :P -
Andreas Kienast uploaded patch set 10 02/24/20, 21:07
-
Nikita Hovratov commented on patch set 10 02/24/20, 21:10
ScriptViewHelper.php:29ReplyDone
-
TYPO3com voted on patch set 9 V -1 02/24/20, 21:17 Completed build in 31m 17s on Mon, 24 Feb, 09:17 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-653
-
Daniel Goerz commented on patch set 10 V -1 02/24/20, 21:26
Examples state that paths starting with 'EXT:' are resolved for JS as well as CSS files which is not the case for either. IMO the AssetCollector should do this only once for the "final" source for any given identifier. This would mean either let the first occurrence of any identifier win (currently the last one wins) and resolve immediately or resolve before returning in the getter. -
Daniel Gohlke commented on patch set 10 02/24/20, 21:28
I like the idea of the AssetCollector.AssetCollector.php:62UnresolvedIs there a reason why StyleSheets use different names for the propterties and the functions Wouldn't it be better to also call $styleSheets and $inlineStyleSheets similar to JavaScript. The function names also differ for the CSS information. In \TYPO3\CMS\Core\Page\AssetRenderer the methods are then called renderStyleSheets and renderInlineStyleSheets. For the JS it should be named the same in the classes, right? In my opinion, would simplify the use. -
Frank Nägler commented on patch set 10 02/24/20, 21:29
> Patch Set 10: Verified-1 > > Examples state that paths starting with 'EXT:' are resolved for JS as well as CSS files which is not the case for either. IMO the AssetCollector should do this only once for the "final" source for any given identifier. This would mean either let the first occurrence of any identifier win (currently the last one wins) and resolve immediately or resolve before returning in the getter. The AssetRenderer take care of the EXT: path rsolving, which IMHO the correct place. Anything before rendering is mangagement/registry scope. -
Daniel Goerz commented on patch set 10 02/24/20, 21:35
> Patch Set 10: > > > Patch Set 10: Verified-1 > > > > Examples state that paths starting with 'EXT:' are resolved for JS as well as CSS files which is not the case for either. IMO the AssetCollector should do this only once for the "final" source for any given identifier. This would mean either let the first occurrence of any identifier win (currently the last one wins) and resolve immediately or resolve before returning in the getter. > > The AssetRenderer take care of the EXT: path rsolving, which IMHO the correct place. > Anything before rendering is mangagement/registry scope. Ah, yes, I just saw that, thats fine, too. Let me find out why this is not working for me, I have <link href="EXT:my_ext/Resources/Public/Css/foo.css" rel="stylesheet" type="text/css" > in my HTML. -
Daniel Goerz commented on patch set 10 CR -1 02/24/20, 21:45
on it -
TYPO3com voted on patch set 10 V +1 02/24/20, 21:49 Completed build in 30m 44s on Mon, 24 Feb, 09:49 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-656
-
Daniel Goerz uploaded patch set 11 02/24/20, 21:56
-
Daniel Goerz voted on patch set 11 V +1 CR +1 02/24/20, 21:57
-
Daniel Gohlke uploaded patch set 12 02/24/20, 22:27
-
Daniel Gohlke voted on patch set 12 CR +1 02/24/20, 22:28
-
TYPO3com voted on patch set 11 V +1 02/24/20, 22:46 Completed build in 40m 23s on Mon, 24 Feb, 10:45 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-665
-
TYPO3com voted on patch set 12 V +1 02/24/20, 22:52 Completed build in 15m 39s on Mon, 24 Feb, 10:51 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-666
-
Georg Ringer voted on patch set 12 CR +1 02/24/20, 22:52
-
Daniel Goerz commented on patch set 12 CR -1 02/24/20, 22:57
AssetCollector.php:46jasaScriptsFeature-90522-IntroduceAssetCollector.rst:48This is now outdated -
Daniel Goerz uploaded patch set 13 02/24/20, 23:08
-
Daniel Goerz voted on patch set 13 V +1 CR +1 02/24/20, 23:09
-
Georg Ringer voted on patch set 13 V +1 CR +1 02/24/20, 23:23
-
TYPO3com voted on patch set 13 V +1 02/24/20, 23:41 Completed build in 27m 47s on Mon, 24 Feb, 11:41 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-668
-
Kevin Appelt voted on patch set 13 V +1 CR +1 02/25/20, 06:00
-
Daniel Gohlke commented on patch set 13 V +1 CR +1 02/25/20, 06:03
AssetCollector.php:46ReplyDoneFeature-90522-IntroduceAssetCollector.rst:48ReplyAck -
Susi Moog voted on patch set 13 V +2 CR +2 02/25/20, 06:05
-
Susi Moog merged patch set 14 02/25/20, 06:05
-
Oli Bartsch commented on patch set 14 02/25/20, 06:14
Great work! Little bit to late but just one question regarding the fallback behavior in the ViewHelpers if no file is given (which means render inline).CssViewHelper.php:97UnresolvedShould we check if this isn’t null?ScriptViewHelper.php:93UnresolvedSame here? -
Oli Bartsch commented on patch set 14 02/26/20, 08:48
> Patch Set 14: > > (2 comments) > > Great work! Little bit to late but just one question regarding the fallback behavior in the ViewHelpers if no file is given (which means render inline). I created a patch for this: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63437