Review 9.5 Merged

63329[FEATURE] Use SiteLanguageAwareInterface to check for trait existence

Oliver Hader CR +2 V +2 Normal +68 −6 updated 02/22/20, 15:03

Commit message

In AspectFactory::enrich(), the function would use class_uses() to
determine, if an aspect uses the trait SiteLanguageAwareTrait. This
however would only work on classes that use this trait, not on classes
that inherit the class with the trait (For example XClasses).
To fix this, a SiteLanguageAwareInterface was introduced, which is
checked against.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 56

  1. Oliver Hader uploaded patch set 1 02/20/20, 07:58

  2. Oliver Hader uploaded patch set 2 02/20/20, 07:59

  3. Oliver Hader rebased onto patch set 3 02/20/20, 23:39

  4. TYPO3com voted on patch set 3 V +1 02/21/20, 01:50 Completed build in 16m 17s on Fri, 21 Feb, 01:50 AM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-59

  5. Oliver Hader voted on patch set 3 V +2 CR +2 02/22/20, 15:02

  6. Oliver Hader merged patch set 4 02/22/20, 15:03