Review main Merged

63330[TASK] Improve visual appearance of feature toggles

Oli Bartsch CR +2 V +2 Normal +35 −21 updated 02/22/20, 08:45

Commit message

This extends and improves the visual appearance of
the feature toggle card in the settings module.

Furthermore the card now reload its content after saving.
This was not the case before and one had to close and reopen
the card to see changes made.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Michael Schams +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2024

  1. Oli Bartsch uploaded patch set 1 02/20/20, 09:02

  2. Oli Bartsch uploaded patch set 2 02/20/20, 09:29

  3. TYPO3com voted on patch set 2 V -1 02/20/20, 10:02 Completed build in 29m 06s on Thu, 20 Feb, 10:02 AM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-335

  4. Michael Schams commented on patch set 2 V -1 02/20/20, 23:05

    Typo in button label "Disbaled" (should read "Disabled"). Buttons not always aligned right, see https://forge.typo3.org/issues/89844#note-5
  5. Oli Bartsch uploaded patch set 3 02/21/20, 21:07

  6. Oli Bartsch commented on patch set 3 02/21/20, 21:11

    > Patch Set 2: Verified-1 > > Typo in button label "Disbaled" (should read "Disabled"). > Buttons not always aligned right, see https://forge.typo3.org/issues/89844#note-5 I switched to the toggle switches as you suggested in the issue. Therefore the toggle switches are now always left with a litte padding to the description. No button label anymore.
  7. Michael Schams commented on patch set 3 V +1 02/21/20, 22:31

    Very nice!
  8. Riccardo De Contardi commented on patch set 3 V +1 02/21/20, 22:47

    Patch works fine, but I am not totally sure about the accordion thing... it needs 2 clicks to enable/disable each setting
  9. TYPO3com voted on patch set 3 V +1 02/21/20, 22:47 Completed build in 46m 10s on Fri, 21 Feb, 10:47 PM Test Summary: 71476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-438

  10. Oli Bartsch commented on patch set 3 02/21/20, 22:57

    > Patch Set 3: Verified+1 > > Patch works fine, but I am not totally sure about the accordion thing... it needs 2 clicks to enable/disable each setting Yes, initially my co-worker made a design where all features were below each other. See https://forge.typo3.org/issues/89844#note-1. But it turned out that this would not improve the clarity. Therefore Michael tried to use the accordion approach which is by the way also used in the other cards like "Configuration Presets" or "Installation-Wide Options". So also the consistency is important here. Furthermore this card won't be used very often I would assume. Thats why I think the 2-step approach is fine here.
  11. Markus Klein commented on patch set 3 02/21/20, 23:03

    I actually dislike the accordions now. What speaks against having all those options visible instantly?
  12. Markus Klein commented on patch set 3 02/21/20, 23:05

    > Patch Set 3: > > I actually dislike the accordions now. What speaks against having all those options visible instantly? Just saw your answer above. Accordions like in Configuration Presets make sense if we have to group multiple options, which is not the case here.
  13. Oli Bartsch uploaded patch set 4 02/21/20, 23:29

  14. Oli Bartsch commented on patch set 4 02/21/20, 23:32

    Because you booth are not really happy with the 2-step approach, patch set 4 is now using the card's style like in the design from the issue.
  15. Markus Klein commented on patch set 4 V +1 02/22/20, 00:12

    Yes, very nice.
  16. Markus Klein commented on patch set 4 V 0 02/22/20, 00:14

    One more thing. While testing I realized that when changing one option the content gets reloaded. So far so good. But the option that has just been clicked moves around. That's rather unexpected to me. I first wondered "where is it gone", and then realized it was sorted "away". Maybe we shouldn't sort the options by their state?
  17. Oli Bartsch uploaded patch set 5 02/22/20, 00:20

  18. Oli Bartsch commented on patch set 5 02/22/20, 00:21

    > Patch Set 4: -Verified > > One more thing. While testing I realized that when changing one option the content gets reloaded. So far so good. But the option that has just been clicked moves around. That's rather unexpected to me. I first wondered "where is it gone", and then realized it was sorted "away". > Maybe we shouldn't sort the options by their state? Yes, you're right. I introduced the sorting because the colored accordions looked really ugly when they were mixed. But with the "new" display the sorting makes not much sense anymore. I removed it.
  19. Markus Klein voted on patch set 5 V +1 CR +1 02/22/20, 00:25

  20. TYPO3com voted on patch set 4 V +1 02/22/20, 01:00 Completed build in 1h 17m 45s on Sat, 22 Feb, 01:00 AM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-446

  21. Michael Schams commented on patch set 5 V +1 02/22/20, 02:20

    Works fine, looks nice, and is more user-friendly than the feature toggles we currently have in 10.2. The only argument against showing all features at once is that you now have a lot of information visible straight away. It takes longer to locate a specific feature as all feature names and their descriptions are shown which is much more text someone has to read/skim when looking for a feature. That said, I also understand the arguments re colors and sort order and the benefits of not having the accordion effect. I assume if the total number of feature toggles increase over time, it will become much harder to use them in the current UI. But maybe let's not worry about this possibility now.
  22. TYPO3com voted on patch set 5 V +1 02/22/20, 02:38 Completed build in 50m 54s on Sat, 22 Feb, 02:38 AM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-451

  23. Benni Mack voted on patch set 5 V +2 CR +2 02/22/20, 08:45

  24. Benni Mack merged patch set 6 02/22/20, 08:45