63331[BUGFIX] Fix cli command aliasing
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Simon Gilli +1
-
Verified V +2 Done
- Susi Moog +2
- Simon Gilli +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2229
Show 34 earlier messages
-
Helmut Hummel uploaded patch set 1 02/20/20, 16:49
-
TYPO3com voted on patch set 1 V +1 02/20/20, 17:06 Completed build in 17m 23s on Thu, 20 Feb, 05:06 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-349
-
Benni Mack voted on patch set 1 V +1 CR +1 02/20/20, 18:39
-
Markus Klein commented on patch set 1 CR +1 02/20/20, 21:14
Minor nitpickConsoleCommandPass.php:63Unresolvedcast is superfluos
-
Helmut Hummel uploaded patch set 2 02/21/20, 12:11
-
TYPO3com voted on patch set 2 V +1 02/21/20, 12:52 Completed build in 31m 37s on Fri, 21 Feb, 12:52 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-394
-
Susi Moog updated the commit message in patch set 3 02/21/20, 14:07
-
Susi Moog voted on patch set 3 CR +1 02/21/20, 14:07
-
TYPO3com voted on patch set 3 V +1 02/21/20, 15:00 Completed build in 39m 39s on Fri, 21 Feb, 03:00 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-404
-
Susi Moog commented on patch set 3 V -1 02/21/20, 16:20
Now the aliases stopped appearing in the list of executable commands (they were there before the patch). Can you check that? -
Helmut Hummel commented on patch set 3 02/21/20, 18:18
In Symfony Console, aliases *never* appear as individual commands, but are shown next to the command itself. That is what happens with this patch. Before this patch, the original command name was lost altogether and only the last alias was shown as command. -
Simon Gilli commented on patch set 3 V -1 02/22/20, 08:55
For me the change is currently fully breaking and I only get the following error: The command defined in "TYPO3\CMS\Core\Command\DumpAutoloadCommand" cannot have an empty name. -
Simon Gilli uploaded patch set 4 02/22/20, 09:41
-
Simon Gilli uploaded patch set 5 02/22/20, 09:42
-
Simon Gilli commented on patch set 5 02/22/20, 09:44
> Patch Set 3: Verified-1 > > For me the change is currently fully breaking and I only get the following error: > > The command defined in "TYPO3\CMS\Core\Command\DumpAutoloadCommand" cannot have an empty name. PS5 should resolve the regression and allows to set the name -
TYPO3com voted on patch set 4 V +1 02/22/20, 10:20 Completed build in 19m 40s on Sat, 22 Feb, 10:20 AM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-461
-
TYPO3com voted on patch set 5 V +1 02/22/20, 10:31 Completed build in 30m 16s on Sat, 22 Feb, 10:31 AM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-462
-
Susi Moog commented on patch set 5 V +1 CR +1 02/22/20, 15:01
> Patch Set 3: > > In Symfony Console, aliases *never* appear as individual commands, but are shown next to the command itself. That is what happens with this patch. > > Before this patch, the original command name was lost altogether and only the last alias was shown as command. Ah, the formatting threw me, didn't notice the alias was printed as part of the description. Last patch set works fine. -
Helmut Hummel commented on patch set 5 CR -1 02/22/20, 15:49
patch set 5 indroduces some unnecessary changes imho. setting the name at runtime is not necessary, because it is done on compile time of the DI container -
Helmut Hummel commented on patch set 5 02/22/20, 15:52
> The command defined in "TYPO3\CMS\Core\Command\DumpAutoloadCommand" cannot have an empty name. Before testing a DI config change, you have to flush the DI cache, otherwise you may run into errors :) That is what I think happend here. -
Simon Gilli uploaded patch set 6 02/22/20, 15:52
-
Simon Gilli commented on patch set 6 V +1 CR +1 02/22/20, 15:54
My regression mentioned before was because of not flushing the cache. So I restored to PS3. Looks fine now, sorry for the confusion! -
TYPO3com voted on patch set 6 V +1 02/22/20, 16:26 Completed build in 15m 41s on Sat, 22 Feb, 04:26 PM Test Summary: 71516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-483
-
Helmut Hummel uploaded patch set 7 02/22/20, 16:27
-
Simon Gilli voted on patch set 7 V +1 CR +1 02/22/20, 16:29
-
TYPO3com voted on patch set 7 V +1 02/22/20, 16:42 Completed build in 14m 55s on Sat, 22 Feb, 04:42 PM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-485
-
Susi Moog voted on patch set 7 V +2 CR +2 02/22/20, 16:45
-
Susi Moog merged patch set 8 02/22/20, 16:45
-
Helmut Hummel commented on patch set 8 02/23/20, 09:57
Thanks!