Review main Merged

63332[BUGFIX] Show fields for files/folders in ElementInformationController

Christian Eßl CR +2 V +2 Hard +181 −113 updated 02/23/20, 15:29

Commit message

The changes made to the ElementInformationController in #88901 had a few
problems and regressions:

- A lot of information for files and folders, that has previously been
shown, was now missing.
- Metadata for files was missing as well, because this information is
saved in a separate table. (sys_file_metadata)

This patch brings back all the lost information. Also, the Metadata of
a file can now be viewed in the ElementInformation window as well.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1216

  1. Christian Eßl uploaded patch set 1 02/20/20, 18:11

  2. TYPO3com voted on patch set 1 V -1 02/20/20, 18:29 Completed build in 17m 54s on Thu, 20 Feb, 06:29 PM Test Summary: 70955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-353

  3. TYPO3com voted on patch set 1 V +1 02/20/20, 19:31 Completed build in 19m 46s on Thu, 20 Feb, 07:31 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-357

  4. Susi Moog uploaded patch set 2 02/22/20, 17:11

  5. Susi Moog voted on patch set 2 V +1 CR +1 02/22/20, 17:12

  6. TYPO3com voted on patch set 2 V +1 02/22/20, 17:25 Completed build in 14m 16s on Sat, 22 Feb, 05:25 PM Test Summary: 71579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-490

  7. Oli Bartsch voted on patch set 2 V +1 02/22/20, 17:38

  8. Daniel Goerz commented on patch set 2 CR -1 02/22/20, 20:44

    ElementInformationController.php:411

    $name is defined in the loop above and it's value is what ever field was iterated last, this can't be right.
  9. Daniel Goerz uploaded patch set 3 02/22/20, 20:55

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 02/22/20, 20:59

  11. Daniel Goerz commented on patch set 3 02/22/20, 21:00

    ElementInformationController.php:411 Reply

    Done
  12. TYPO3com voted on patch set 3 V +1 02/22/20, 21:33 Completed build in 35m 40s on Sat, 22 Feb, 09:33 PM Test Summary: 71580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-515

  13. Oli Bartsch voted on patch set 3 V +1 CR +1 02/22/20, 21:43

  14. Christian Eßl voted on patch set 3 V +1 CR +1 02/23/20, 08:26

  15. Daniel Goerz voted on patch set 3 V +2 CR +2 02/23/20, 15:29

  16. Daniel Goerz merged patch set 4 02/23/20, 15:29