63336[FEATURE] Add JavaScript event handling API
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Markus Klein +1
-
Verified V +2 Done
- Susi Moog +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 14
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/InlineControlContainer.ts2+170 −240
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Event/DebounceEvent.tsnew+53 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Event/EventInterface.tsnew+20 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Event/RegularEvent.ts3new+48 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Event/RequestAnimationFrameEvent.tsnew+45 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Event/ThrottleEvent.tsnew+44 −0
- Build/eslintrc.js+1 −5
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-90471-JavaScriptEventAPI.rstnew+186 −0
- typo3/sysext/core/Resources/Public/JavaScript/Event/DebounceEvent.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/Event/EventInterface.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/Event/RegularEvent.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/Event/RequestAnimationFrameEvent.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/Event/ThrottleEvent.jsnew+13 −0
Review log 1822
-
Andreas Kienast uploaded patch set 1 02/20/20, 19:25
-
TYPO3com voted on patch set 1 V +1 02/20/20, 20:03 Completed build in 30m 29s on Thu, 20 Feb, 08:03 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-360
-
Andreas Kienast uploaded patch set 2 02/20/20, 21:24
-
Benni Mack commented on patch set 2 02/20/20, 21:40
-
Andreas Kienast uploaded patch set 3 02/20/20, 22:11
-
TYPO3com voted on patch set 3 V +1 02/20/20, 23:43 Completed build in 1h 04m 27s on Thu, 20 Feb, 11:43 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-372
-
Andreas Kienast uploaded patch set 4 02/21/20, 16:31
-
Markus Klein commented on patch set 4 02/21/20, 16:57
RegularEvent.ts:44If I register the same event with the same callback multiple times, this will not achieve the desired functionality. Did you check the jquery source how the uniquely identify the registered handlers? -
Markus Klein commented on patch set 4 02/21/20, 16:58
General question: couldn't we use the rxjs library for this? It is capable of all this already, afaik -
Markus Klein commented on patch set 4 02/21/20, 16:58
Sorry, forgot the link https://rxjs.dev/guide/overview -
Andreas Kienast commented on patch set 4 02/21/20, 17:05
> Patch Set 4: > > General question: couldn't we use the rxjs library for this? > It is capable of all this already, afaik We might use that library instead, but I don't have any knowledge in that one. Somebody else has to step in then.RegularEvent.ts:44ReplyNo, I didn't. But why would one do that? -
TYPO3com voted on patch set 4 V +1 02/21/20, 17:49 Completed build in 1h 05m 28s on Fri, 21 Feb, 05:49 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-419
-
Markus Klein commented on patch set 4 02/21/20, 19:08
> Patch Set 4: > > (1 comment) > > > Patch Set 4: > > > > General question: couldn't we use the rxjs library for this? > > It is capable of all this already, afaik > > We might use that library instead, but I don't have any knowledge in that one. Somebody else has to step in then. I'll check if it would be suitable for us, or if it is overkill. This lib is a basis used in Angular for instance. It's all about observables. (which are basically better than Promises)RegularEvent.ts:44Reply UnresolvedWell, this should be a generic lib, so it should cover those edge-cases. I don't have a concrete example, where this might be the case, but I just wanted to point out that the potential issue exists. -
Markus Klein commented on patch set 4 02/21/20, 19:12
> Patch Set 4: > > (1 comment) > > > Patch Set 4: > > > > (1 comment) > > > > > Patch Set 4: > > > > > > General question: couldn't we use the rxjs library for this? > > > It is capable of all this already, afaik > > > > We might use that library instead, but I don't have any knowledge in that one. Somebody else has to step in then. > > I'll check if it would be suitable for us, or if it is overkill. This lib is a basis used in Angular for instance. It's all about observables. (which are basically better than Promises) Okay, it would maybe be a bit too much to throw that one in for now. We could take the lib as a possible goal for v11 and replace Promises bit by bit with Obserables. -
Markus Klein commented on patch set 4 02/21/20, 19:17
InlineControlContainer.ts:237why not a RegularEvent? -
Andreas Kienast commented on patch set 4 02/21/20, 19:27
InlineControlContainer.ts:237Reply UnresolvedI missed that one, I'll fix that ASAP -
Andreas Kienast uploaded patch set 5 02/21/20, 20:45
-
Markus Klein voted on patch set 5 CR +1 02/21/20, 22:07
-
Markus Klein voted on patch set 5 V +1 02/21/20, 22:11
-
TYPO3com voted on patch set 5 V +1 02/21/20, 22:37 Completed build in 1h 02m 18s on Fri, 21 Feb, 10:37 PM Test Summary: 71474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-437
-
Susi Moog voted on patch set 5 V +2 CR +2 02/22/20, 16:43
-
Susi Moog merged patch set 6 02/22/20, 16:43
AbstractEvent.ts:16Unresolved