Review main Merged

63337[BUGFIX] Don't assign undefined variable to template of Dashboard

Richard Haeser CR +2 V +2 Easy +0 −1 updated 02/20/20, 22:29

Commit message

As $this->settings is not defined, it should not be passed to the Fluid
template of the DashboardController.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Siepmann +1
    • Koen Wouters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Siepmann +1

Issues 1

Files 1

Review log 810

  1. Richard Haeser uploaded patch set 1 02/20/20, 20:43

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 02/20/20, 20:49

  3. Claus Due voted on patch set 1 CR +1 02/20/20, 20:49

  4. Daniel Siepmann updated the commit message in patch set 2 02/20/20, 20:49

  5. Daniel Siepmann voted on patch set 2 V +1 CR +1 02/20/20, 20:51

  6. Koen Wouters voted on patch set 2 CR +1 02/20/20, 20:59

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/20/20, 21:35

  8. Benni Mack merged patch set 3 02/20/20, 21:35

  9. TYPO3com voted on patch set 1 V +1 02/20/20, 21:36 Completed build in 49m 40s on Thu, 20 Feb, 09:36 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-365

  10. TYPO3com voted on patch set 2 V +1 02/20/20, 22:29 Completed build in 1h 02m 30s on Thu, 20 Feb, 10:29 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-366