Review main Abandoned

63338[WIP][TASK] Refactor AbstractMenuContentObject

Nikita Hovratov CR 0 V 0 Nightmare +1528 −1021 updated 06/30/20, 20:12

Commit message

The strategy for the menu classes is to collect all implicitly
declared configuration keys and put them into separate default arrays.
This way it is ensured that the keys exist and we don't have to check
every access to the conf array.

Nice side effect is better code documentation since all available
configuration keys with their default values are listed in one place.

Extract the special menu types (list, language, ...) into separate
classes and let them implement the TypeInterface with the method
"prepare".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 20

Review log 2140

Show 815 earlier messages
  1. Nikita Hovratov uploaded patch set 1 02/20/20, 21:46

  2. Nikita Hovratov marked it work in progress 02/20/20, 21:46

  3. TYPO3com voted on patch set 1 V +1 02/20/20, 23:08 Completed build in 1h 04m 23s on Thu, 20 Feb, 11:08 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-370

  4. Nikita Hovratov uploaded patch set 2 02/22/20, 01:40

  5. TYPO3com voted on patch set 2 V -1 02/22/20, 01:48 Completed build in 54s on Sat, 22 Feb, 01:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-452

  6. Nikita Hovratov uploaded patch set 3 02/22/20, 01:49

  7. TYPO3com voted on patch set 3 V -1 02/22/20, 02:29 Completed build in 51s on Sat, 22 Feb, 02:29 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-453

  8. Nikita Hovratov uploaded patch set 4 02/22/20, 18:03

  9. TYPO3com voted on patch set 4 V -1 02/22/20, 18:04 Completed build in 31s on Sat, 22 Feb, 06:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-496

  10. Nikita Hovratov uploaded patch set 5 02/22/20, 18:19

  11. TYPO3com voted on patch set 5 V -1 02/22/20, 18:34 Completed build in 33s on Sat, 22 Feb, 06:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-499

  12. Nikita Hovratov uploaded patch set 6 02/22/20, 18:37

  13. TYPO3com voted on patch set 6 V -1 02/22/20, 19:24 Completed build in 31m 27s on Sat, 22 Feb, 07:24 PM Test Summary: 349 of 72066 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-504

  14. Nikita Hovratov uploaded patch set 7 02/22/20, 21:00

  15. TYPO3com voted on patch set 7 V -1 02/22/20, 21:50 Completed build in 43m 30s on Sat, 22 Feb, 09:50 PM Test Summary: 78 of 72067 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-516

  1. Nikita Hovratov uploaded patch set 8 02/22/20, 23:17

  2. TYPO3com voted on patch set 8 V -1 02/22/20, 23:17 Completed build in 26s on Sat, 22 Feb, 11:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-523

  3. Nikita Hovratov uploaded patch set 9 02/22/20, 23:20

  4. TYPO3com voted on patch set 9 V -1 02/22/20, 23:21 Completed build in 29s on Sat, 22 Feb, 11:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-524

  5. Nikita Hovratov uploaded patch set 10 02/22/20, 23:25

  6. TYPO3com voted on patch set 10 V -1 02/22/20, 23:51 Completed build in 18m 17s on Sat, 22 Feb, 11:51 PM Test Summary: 18 of 72073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-526

  7. Nikita Hovratov uploaded patch set 11 02/23/20, 11:46

  8. TYPO3com voted on patch set 11 V +1 02/23/20, 12:12 Completed build in 21m 23s on Sun, 23 Feb, 12:12 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-548

  9. Nikita Hovratov uploaded patch set 12 02/23/20, 21:36

  10. TYPO3com voted on patch set 12 V +1 02/23/20, 21:54 Completed build in 15m 57s on Sun, 23 Feb, 09:54 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-589

  11. Nikita Hovratov uploaded patch set 13 02/24/20, 21:50

  12. TYPO3com voted on patch set 13 V +1 02/24/20, 22:30 Completed build in 24m 42s on Mon, 24 Feb, 10:30 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-663

  13. Nikita Hovratov uploaded patch set 14 02/26/20, 19:54

  14. TYPO3com voted on patch set 14 V -1 02/26/20, 19:54 Completed build in 23s on Wed, 26 Feb, 07:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-724

  15. Nikita Hovratov uploaded patch set 15 02/26/20, 20:20

  16. TYPO3com voted on patch set 15 V -1 02/26/20, 20:31 Completed build in 10m 58s on Wed, 26 Feb, 08:31 PM Test Summary: 30 of 72470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-725

  17. Nikita Hovratov uploaded patch set 16 02/26/20, 21:01

  18. TYPO3com voted on patch set 16 V -1 02/26/20, 21:21 Completed build in 16m 52s on Wed, 26 Feb, 09:21 PM Test Summary: 69239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-726

  19. Nikita Hovratov rebased onto patch set 17 02/28/20, 22:57

  20. TYPO3com voted on patch set 17 V -1 02/28/20, 23:09 Completed build in 12m 08s on Fri, 28 Feb, 11:09 PM Test Summary: 1 of 72535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-827

  21. Nikita Hovratov uploaded patch set 18 02/28/20, 23:11

  22. TYPO3com voted on patch set 18 V -1 02/28/20, 23:28 Completed build in 17m 15s on Fri, 28 Feb, 11:28 PM Test Summary: 71743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-828

  23. Nikita Hovratov uploaded patch set 19 04/06/20, 08:03

  24. TYPO3com voted on patch set 19 V -1 04/06/20, 08:04 Completed build in 12s on Mon, 6 Apr, 08:04 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2216

  25. Nikita Hovratov abandoned the change 06/30/20, 20:12

    Need to do this in smaller steps