63349[BUGFIX] Allow multiple mountpoints with the same slug
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Patrick Broens +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Patrick Broens +1
- Dirk Koritnik +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php1+40 −16
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/MountPointScenario.yaml+24 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php+37 −1
Review log 1734
Show 69 earlier messages
-
Patrick Broens uploaded patch set 1 02/21/20, 15:23
-
TYPO3com voted on patch set 1 V -1 02/21/20, 16:22 Completed build in 50m 23s on Fri, 21 Feb, 04:22 PM Test Summary: 225 of 71920 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-412
-
Benni Mack updated the commit message in patch set 2 03/04/20, 08:03
-
TYPO3com voted on patch set 2 V -1 03/04/20, 08:45 Completed build in 25m 43s on Wed, 4 Mar, 08:45 AM Test Summary: 225 of 72598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-968
-
Christian Eßl commented on patch set 2 CR -1 03/05/20, 14:17
-
Benni Mack uploaded patch set 3 03/07/20, 20:50
-
Benni Mack uploaded patch set 4 03/07/20, 20:56
-
Benni Mack rebased onto patch set 5 03/07/20, 20:57
-
TYPO3com voted on patch set 3 V -1 03/07/20, 21:03 Completed build in 13m 04s on Sat, 7 Mar, 09:03 PM Test Summary: 12 of 72579 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1103
-
TYPO3com voted on patch set 4 V -1 03/07/20, 21:09 Completed build in 12m 24s on Sat, 7 Mar, 09:09 PM Test Summary: 12 of 72579 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1104
-
TYPO3com voted on patch set 5 V -1 03/07/20, 21:14 Completed build in 14m 33s on Sat, 7 Mar, 09:14 PM Test Summary: 12 of 72579 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1105
-
Benni Mack uploaded patch set 6 03/08/20, 10:02
-
TYPO3com voted on patch set 6 V -1 03/08/20, 10:14 Completed build in 12m 00s on Sun, 8 Mar, 10:14 AM Test Summary: 12 of 71762 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1115
-
Benni Mack uploaded patch set 7 03/31/20, 11:02
-
TYPO3com voted on patch set 7 V -1 03/31/20, 11:13 Completed build in 11m 37s on Tue, 31 Mar, 11:13 AM Test Summary: 46 of 73539 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2020
-
TYPO3com commented on patch set 7 03/31/20, 11:49 Completed build in 59m 20s on Tue, 31 Mar, 11:49 AM Test Summary: 32 of 73539 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2020
-
TYPO3com commented on patch set 7 03/31/20, 12:39 Completed build in 2h 36m 21s on Tue, 31 Mar, 12:39 PM Test Summary: 62 of 73538 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2020
-
TYPO3com commented on patch set 7 03/31/20, 17:20 Completed build in 8h 54m 57s on Tue, 31 Mar, 05:20 PM Test Summary: 3 of 73536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2020
-
Benni Mack rebased onto patch set 8 04/02/20, 10:20
-
TYPO3com voted on patch set 8 V -1 04/02/20, 10:39 Completed build in 15m 04s on Thu, 2 Apr, 10:39 AM Test Summary: 4 of 73744 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2089
-
TYPO3com commented on patch set 8 04/02/20, 19:23 Completed build in 9h 13m 52s on Thu, 2 Apr, 07:23 PM Test Summary: 3 of 73744 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2089
-
Benni Mack uploaded patch set 9 04/02/20, 19:51
-
TYPO3com commented on patch set 8 04/02/20, 19:56 Completed build in 18h 46m 27s on Thu, 2 Apr, 07:56 PM Test Summary: 3 of 73744 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2089
-
TYPO3com voted on patch set 9 V -1 04/02/20, 20:02 Completed build in 10m 42s on Thu, 2 Apr, 08:02 PM Test Summary: 3 of 73744 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2106
-
Benni Mack uploaded patch set 10 04/02/20, 21:10
-
Benni Mack uploaded patch set 11 04/02/20, 21:12
-
TYPO3com voted on patch set 10 V -1 04/02/20, 21:26 Completed build in 15m 52s on Thu, 2 Apr, 09:26 PM Test Summary: 199 of 73106 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2109
-
TYPO3com voted on patch set 11 V -1 04/02/20, 21:42 Completed build in 25m 22s on Thu, 2 Apr, 09:42 PM Test Summary: 26 of 73734 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2110
-
TYPO3com voted on patch set 11 V +1 04/03/20, 06:03 Completed build in 9h 12m 03s on Fri, 3 Apr, 06:03 AM Test Summary: 73260 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2110
-
Patrick Broens voted on patch set 11 V +1 CR +1 04/03/20, 07:56
-
Dirk Koritnik voted on patch set 11 V +1 04/03/20, 09:54
-
Susi Moog voted on patch set 11 CR +1 04/16/20, 08:59
-
Benni Mack voted on patch set 11 V +2 CR +2 04/16/20, 10:16
-
Benni Mack merged patch set 12 04/16/20, 10:16
PageSlugCandidateProvider.php:235Unresolved