Review main Merged

63351[BUGFIX] Use json_encode instead of implode

Susi Moog CR +2 V +2 Easy +1 −1 updated 02/21/20, 16:21

Commit message

To ensure unique identifiers for query entries the
backtrace is considered as part of the hash. As the
backtrace is multidimensional, stringification is no
longer done by using implode.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Susi Moog uploaded patch set 1 02/21/20, 15:28

  2. Daniel Goerz voted on patch set 1 V +1 CR +1 02/21/20, 15:29

  3. TYPO3com voted on patch set 1 V +1 02/21/20, 16:12 Completed build in 39m 12s on Fri, 21 Feb, 04:12 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-414

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 02/21/20, 16:21

  5. Andreas Kienast merged patch set 2 02/21/20, 16:21