Review main Abandoned

63353[WIP][BUGFIX] Add missing database indices

Jonas Eberle CR 0 V 0 Normal +70 −14 updated 10/23/23, 12:18

Commit message

Identify and remedy queries on non-indexed constraints.

When ready, this patch would contain some changes to .sql files and the
DefaultTcaSchema auto-index-generation.

Currently used commands:

Build/Scripts/runTests.sh -s functional -e "--stop-on-failure"
Build/Scripts/runTests.sh -s acceptance -e "--stop-on-failure"

After finishing these will output the file where logs were written.

Run this to see log while running tests:
  docker-compose exec mariadb10 sh -c 'tail --follow=name --retry \
    --lines=+0 /var/log/mysql/mariadb-slow.log' \
    | grep -Ei '^select.*(where|order|group by|join.*on)' \
    | grep -Ev 'tx_(expressionbuildertest|styleguide|irretutorial)|
information_schema|sys_(log|history)'

Statistics:
lines matching the filter above in slow query log:
      master: 14608
  patchset 4: 6723 (problems with postgres)
  patchset 5: 8137

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1419

  1. Jonas Eberle uploaded patch set 1 02/21/20, 17:57

  2. TYPO3com voted on patch set 1 V +1 02/21/20, 18:21 Completed build in 20m 05s on Fri, 21 Feb, 06:21 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-422

  3. Jonas Eberle uploaded patch set 2 02/21/20, 19:09

  4. TYPO3com voted on patch set 2 V -1 02/21/20, 19:30 Completed build in 21m 05s on Fri, 21 Feb, 07:30 PM Test Summary: 22 of 71932 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-427

  5. Jonas Eberle uploaded patch set 3 02/21/20, 22:41

  6. TYPO3com voted on patch set 3 V -1 02/22/20, 00:39 Completed build in 57m 23s on Sat, 22 Feb, 12:39 AM Test Summary: 31 of 71974 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-444

  7. Jonas Eberle updated the commit message in patch set 4 02/22/20, 06:40

  8. TYPO3com voted on patch set 4 V -1 02/22/20, 07:00 Completed build in 20m 09s on Sat, 22 Feb, 07:00 AM Test Summary: 27 of 71974 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-456

  9. Jonas Eberle uploaded patch set 5 02/25/20, 00:29

  10. TYPO3com voted on patch set 5 V +1 02/25/20, 00:43 Completed build in 12m 59s on Tue, 25 Feb, 12:43 AM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-669

  11. Jonas Eberle commented on patch set 5 04/18/20, 00:55

    I'll wait for the new master branch-off before continuing here
  12. Patrick Schriner commented on patch set 5 CR -1 05/15/20, 13:52

    ext_tables.sql:121

    uid is the primary key, the best possible index already exists
  13. Jonas Eberle commented on patch set 5 05/15/20, 15:21

    ext_tables.sql:121 Reply

    Ack
  14. Benni Mack updated the commit message in patch set 6 05/25/20, 18:51

  15. Jonas Eberle marked it work in progress 09/09/21, 09:54

  16. Benni Mack wrote 11/29/21, 10:09

    Change destination moved from master to main
  17. Benni Mack updated the commit message in patch set 7 11/29/21, 13:27

  18. Christian Kuhn commented on patch set 7 10/23/23, 12:18

    Hey. I hope it's ok to abandon here for now: This patch hasn't been worked on for two years. In general, I think it does not make much sense in trying to pick *all* queries that don't use indexes, for instance, it's not needed for tables that have so little rows that mysql will do a manual scan anyways. We can of course always look up single 'missing index' occurrences and eventually add some if needed. This can be done with single and fresh patches.

    ext_tables.sql:121 Unresolved

    there is no point on adding an additional index on the primary key column.
  19. Christian Kuhn abandoned the change 10/23/23, 12:18