Review main Merged

63355[BUGFIX] Show guidelines in Adminpanel rendering tree view

Tymoteusz Motylewski CR +2 V +2 Easy +20 −21 updated 03/03/20, 20:14

Commit message

The tree guidelines are now properly shown in the TS Tree view
in AdminPanel.
Also not used FontAwesome is removed from AdminPanel

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Eßl +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 914

  1. Tymoteusz Motylewski uploaded patch set 1 02/21/20, 19:24

  2. Tymoteusz Motylewski uploaded patch set 2 02/21/20, 19:34

  3. Tymoteusz Motylewski commented on patch set 2 V -1 02/21/20, 19:35

    The lines are show now, but sth is still wrong with the font awesome icon. Help from somebody with better frontend skills needed.
  4. TYPO3com voted on patch set 1 V +1 02/21/20, 19:43 Completed build in 19m 18s on Fri, 21 Feb, 07:43 PM Test Summary: 71476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-428

  5. TYPO3com voted on patch set 2 V +1 02/21/20, 20:05 Completed build in 30m 15s on Fri, 21 Feb, 08:05 PM Test Summary: 71476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-430

  6. Tymoteusz Motylewski uploaded patch set 3 02/24/20, 09:02

  7. TYPO3com voted on patch set 3 V +1 02/24/20, 09:35 Completed build in 18m 46s on Mon, 24 Feb, 09:35 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-602

  8. Christian Eßl commented on patch set 3 V -1 02/26/20, 06:42

    Icons still look weird. Second text line lies over the dotted line (needs an indent)
  9. Tymoteusz Motylewski uploaded patch set 4 03/03/20, 11:30

  10. TYPO3com voted on patch set 4 V -1 03/03/20, 11:40 Completed build in 09m 41s on Tue, 3 Mar, 11:40 AM Test Summary: 71607 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-946

  11. Christian Eßl voted on patch set 4 V +1 CR +1 03/03/20, 11:52

  12. TYPO3com voted on patch set 4 V +1 03/03/20, 11:52 Completed build in 31m 46s on Tue, 3 Mar, 11:52 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-946

  13. Georg Ringer voted on patch set 4 V +2 CR +2 03/03/20, 20:14

  14. Georg Ringer merged patch set 5 03/03/20, 20:14