Review main Merged

63360[BUGFIX] Fix wrong field name in be_dashboard TCA

Christian Eßl CR +2 V +2 Easy +8 −8 updated 02/22/20, 01:46

Commit message

The TCA for be_dashboard was using a field name that doesn't exist
in the database table.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 812

  1. Christian Eßl uploaded patch set 1 02/21/20, 20:43

  2. Oli Bartsch commented on patch set 1 02/21/20, 21:59

    Should the column also be renamed to `title`?
  3. Daniel Goerz uploaded patch set 2 02/21/20, 22:00

  4. Daniel Goerz commented on patch set 2 V +1 CR +1 02/21/20, 22:01

    It needs to be title everywhere since that is the name of the database field :)
  5. Oli Bartsch uploaded patch set 3 02/21/20, 22:02

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 02/21/20, 22:03

  7. Daniel Goerz voted on patch set 3 V +2 CR +2 02/21/20, 22:04

  8. TYPO3com voted on patch set 1 V +1 02/21/20, 22:26 Completed build in 51m 21s on Fri, 21 Feb, 10:26 PM Test Summary: 71476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-436

  9. TYPO3com voted on patch set 2 V +1 02/21/20, 23:40 Completed build in 1h 37m 57s on Fri, 21 Feb, 11:40 PM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-440

  10. TYPO3com voted on patch set 3 V +1 02/22/20, 00:02 Completed build in 1h 23m 47s on Sat, 22 Feb, 12:02 AM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-441

  11. Daniel Goerz merged patch set 4 02/22/20, 00:03

  12. TYPO3com commented on patch set 3 02/22/20, 01:46 Completed build in 2h 04m 02s on Sat, 22 Feb, 01:46 AM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-447