Review main Merged

63362[TASK] Styling cleanups in several modules

Benjamin Kott CR +2 V +2 Expert +684 −1426 updated 02/22/20, 21:27

Commit message

This patch cleans up stylings across various modules and
streamlines the used markup as well as the folder structure.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 65

Show 45 more files

Review log 1927

Show 12 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/21/20, 23:28

  2. TYPO3com voted on patch set 1 V -1 02/22/20, 00:49 Completed build in 1h 06m 57s on Sat, 22 Feb, 12:49 AM Test Summary: 1 of 71974 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-445

  1. Benjamin Kott uploaded patch set 2 02/22/20, 09:21

  2. Oliver Klee commented on patch set 2 CR -1 02/22/20, 09:33

    The ticket ID is still missing.
  3. Benjamin Kott commented on patch set 2 02/22/20, 09:34

    youre right, forgot to mark it as wip
  4. Benjamin Kott marked it work in progress 02/22/20, 09:35

  5. TYPO3com voted on patch set 2 V +1 02/22/20, 10:10 Completed build in 40m 06s on Sat, 22 Feb, 10:10 AM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-460

  6. Benjamin Kott uploaded patch set 3 02/22/20, 10:59

  7. TYPO3com voted on patch set 3 V -1 02/22/20, 11:22 Completed build in 19m 04s on Sat, 22 Feb, 11:22 AM Test Summary: 2 of 71974 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-464

  8. Benjamin Kott uploaded patch set 4 02/22/20, 14:06

  9. TYPO3com voted on patch set 4 V -1 02/22/20, 15:15 Completed build in 31m 57s on Sat, 22 Feb, 03:15 PM Test Summary: 1 of 71974 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-475

  10. Benjamin Kott uploaded patch set 5 02/22/20, 15:55

  11. TYPO3com voted on patch set 5 V +1 02/22/20, 16:34 Completed build in 23m 17s on Sat, 22 Feb, 04:34 PM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-484

  12. Benjamin Kott uploaded patch set 6 02/22/20, 16:42

  13. TYPO3com voted on patch set 6 V +1 02/22/20, 16:57 Completed build in 15m 07s on Sat, 22 Feb, 04:57 PM Test Summary: 71517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-488

  14. Benjamin Kott uploaded patch set 7 02/22/20, 17:15

  15. Benjamin Kott commented on patch set 7 02/22/20, 17:17

    This change is ready for review.
  16. TYPO3com voted on patch set 7 V +1 02/22/20, 17:33 Completed build in 16m 22s on Sat, 22 Feb, 05:33 PM Test Summary: 71580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-491

  17. Andreas Kienast voted on patch set 7 V +1 CR +1 02/22/20, 17:42

  18. Benjamin Kott uploaded patch set 8 02/22/20, 17:43

  19. Andreas Kienast voted on patch set 8 V +1 CR +1 02/22/20, 17:44

  20. TYPO3com voted on patch set 8 V +1 02/22/20, 17:59 Completed build in 16m 04s on Sat, 22 Feb, 05:59 PM Test Summary: 71580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-494

  21. Susi Moog voted on patch set 8 V +2 CR +2 02/22/20, 17:59

  22. Susi Moog merged patch set 9 02/22/20, 17:59

  23. Daniel Goerz commented on patch set 9 02/22/20, 21:23

    QueryGenerator.php:1006

    The removed variable $indent is still used here
  24. Benjamin Kott commented on patch set 9 02/22/20, 21:25

    QueryGenerator.php:1006 Reply Unresolved

    you are right, will push a followup
  25. Daniel Goerz commented on patch set 9 02/22/20, 21:27