Review main Merged

63369[TASK] Harden types in ext:dashboard

Oli Bartsch CR +2 V +2 Easy +5 −6 updated 02/22/20, 14:22

Commit message

* Add some missing return types
* Remove wrong return type annotation
* Add missing import
* Use strict mode for `in_array`

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Oli Bartsch uploaded patch set 1 02/22/20, 13:01

  2. Richard Haeser voted on patch set 1 V +1 CR +1 02/22/20, 13:07

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 02/22/20, 13:15

  4. TYPO3com voted on patch set 1 V +1 02/22/20, 14:21 Completed build in 55m 11s on Sat, 22 Feb, 02:21 PM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-469

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 02/22/20, 14:22

  6. Daniel Goerz merged patch set 2 02/22/20, 14:22