Review main Merged

63370[BUGFIX] Fallback to default, if BackendLayout can no longer be resolved

Christian Eßl CR +2 V +2 Easy +8 −0 updated 02/23/20, 20:15

Commit message

In the new fluidbased page module view, if a previously configured
BackendLayout has been removed. (For instance, the extension providing
it has been removed), the module would throw an uncaught error, because
the script would try to call a method on a non-existing BackendLayout.

This patch fixes this problem by automatically falling back to the
"default" BackendLayout, if the requested one couldn't be provided.
This is the same way as the old PageLayoutView would have reacted to
this problem.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Claus Due +1
    • Oli Bartsch +1
    • Kevin Appelt +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Claus Due +1
    • Kevin Appelt +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Christian Eßl uploaded patch set 1 02/22/20, 13:09

  2. Claus Due commented on patch set 1 02/22/20, 13:19

    Good catch - but I think we should implement the fallback in PageLayoutController:548 and make return from BackendLayoutView->getSelectedBackendLayoutObject nullable, so we avoid potentially affecting PageLayoutView. Although I can't think of any current use cases it would make sense that the DataProviderCollection returns null if a record or pageTSconfig is removed. What do you think about this approach?
  3. TYPO3com voted on patch set 1 V +1 02/22/20, 14:52 Completed build in 1h 06m 10s on Sat, 22 Feb, 02:52 PM Test Summary: 71518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-472

  4. Christian Eßl rebased onto patch set 2 02/23/20, 08:35

  5. Christian Eßl uploaded patch set 3 02/23/20, 08:37

  6. TYPO3com voted on patch set 2 V +1 02/23/20, 08:51 Completed build in 15m 10s on Sun, 23 Feb, 08:51 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-530

  7. TYPO3com voted on patch set 3 V +1 02/23/20, 09:03 Completed build in 15m 26s on Sun, 23 Feb, 09:03 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-532

  8. Claus Due voted on patch set 3 V +1 CR +1 02/23/20, 10:41

  9. Daniel Siepmann commented on patch set 3 02/23/20, 10:50

    Maybe we should add an infobox with a warning, that currently selected layout is not available? Would at least be an improvement.
  10. Kevin Appelt voted on patch set 3 V +1 CR +1 02/23/20, 10:52

  11. Kevin Appelt commented on patch set 3 02/23/20, 10:55

    > Patch Set 3: > > Maybe we should add an infobox with a warning, that currently selected layout is not available? Would at least be an improvement. I like the idea, but it should not be part of this patch IMO. Also, if we add the hint, it should appear in both the fluid and the old view.
  12. Claus Due commented on patch set 3 02/23/20, 10:55

    > Patch Set 3: > > Maybe we should add an infobox with a warning, that currently selected layout is not available? Would at least be an improvement. I would be happy to but this should be as a separate patch - the legacy PageLayoutView does not render such a warning and the immediate goal is to make the rewritten UI visually and functionally identical to the old, from an editor perspective.
  13. Daniel Siepmann commented on patch set 3 02/23/20, 10:58

    > Patch Set 3: > > > Patch Set 3: > > > > Maybe we should add an infobox with a warning, that currently selected layout is not available? Would at least be an improvement. > > I would be happy to but this should be as a separate patch - the legacy PageLayoutView does not render such a warning and the immediate goal is to make the rewritten UI visually and functionally identical to the old, from an editor perspective. Sure, go ahead :) Would be an separate improvement.
  14. Oli Bartsch voted on patch set 3 CR +1 02/23/20, 11:34

  15. Georg Ringer voted on patch set 3 V +2 CR +2 02/23/20, 20:15

  16. Georg Ringer merged patch set 4 02/23/20, 20:15