Review main Merged

63372[BUGFIX] Throw missing exception in method getTypeOfChildProperty

Alexander Schnitzler CR +2 V +2 Normal +85 −11 updated 02/27/20, 18:49

Commit message

Method getTypeOfChildProperty() of class ObjectConverter
didn't throw an exception if the class schema didn't detect
a type for the given child property. This could have led to
the case where said method returned void and resulted in a
type error exception.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Alexander Schnitzler uploaded patch set 1 02/22/20, 15:38

  2. TYPO3com voted on patch set 1 V -1 02/22/20, 16:13 Completed build in 22m 00s on Sat, 22 Feb, 04:13 PM Test Summary: 3 of 71974 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-481

  3. Alexander Schnitzler uploaded patch set 2 02/23/20, 10:38

  4. TYPO3com voted on patch set 2 V +1 02/23/20, 11:10 Completed build in 15m 49s on Sun, 23 Feb, 11:10 AM Test Summary: 71592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-541

  5. Alexander Schnitzler commented on patch set 2 02/23/20, 12:13

    This change is ready for review.
  6. Alexander Schnitzler wrote 02/23/20, 12:13

    Topic set to extbase
  7. Daniel Goerz commented on patch set 3 02/23/20, 15:48

    Published edit on patch set 2.
  8. Daniel Goerz voted on patch set 3 CR +1 02/23/20, 15:49

  9. TYPO3com voted on patch set 3 V +1 02/23/20, 16:01 Completed build in 13m 18s on Sun, 23 Feb, 04:01 PM Test Summary: 71592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-571

  10. Daniel Goerz voted on patch set 3 V +1 02/27/20, 16:56

  11. Susi Moog voted on patch set 3 V +2 CR +2 02/27/20, 18:49

  12. Susi Moog merged patch set 4 02/27/20, 18:49