Review main Merged

6338[TASK] Clean up about modules extension

Christian Kuhn CR +2 V +2 Normal +124 −56 updated 06/03/13, 20:49

Commit message

tx_aboutmodules_Functions was used in the good old days to render the main
module menus. Now, the only code that used this class was the about module
extension. The patch refactors the about module and moves the needed code of
the tx_aboutmodules_Functions to its own class. This makes the extension
way easier to maintain.
tx_aboutmodules_Functions is declared obsolete and unmaintained.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2
    • Christian Kuhn +2
    • Steffen Ritter +1

Issues 1

Files 2

Review log 12

  1. Stefan Neufeind uploaded patch set 2 12/12/11, 12:57

  2. Stefan Neufeind commented on patch set 2 12/12/11, 12:57

    Looks good to me, but someone else must approve just added typehint pointed out by Xavier. rest looks okay imho. 2x +1 from Helmut still apply
  3. Oliver Hader uploaded patch set 3 12/12/11, 12:57

  4. Oliver Hader commented on patch set 3 12/12/11, 12:57

    Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de>
  5. Xavier Perseguers commented on patch set 1 12/12/11, 12:57

    (1 inline comment)

    index.php:92

    missing 'array' type hint
  6. Helmut Hummel commented on patch set 1 12/12/11, 12:57

    Verified; Looks good to me, but someone else must approve
  7. Christian Kuhn commented on patch set 3 V 0 12/12/11, 12:57

    by team member; Looks good to me, approved Reviews complete together with Helumts review of patch Set #1, only the array type hinting changed meanwhile. Merged.
  8. Steffen Ritter commented on patch set 3 12/12/11, 12:57

    Verified; Looks good to me, approved
  9. Mr. Jenkins commented on patch set 1 12/12/11, 12:57

  10. Mr. Jenkins commented on patch set 2 12/12/11, 12:57

  11. Mr. Jenkins commented on patch set 3 12/12/11, 12:57

  12. Christian Kuhn merged patch set 3 12/12/11, 12:57