6338[TASK] Clean up about modules extension
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Christian Kuhn +2
- Oliver Hader +1
-
Verified V +2
- Christian Kuhn +2
- Steffen Ritter +1
Issues 1
Files 2
Review log 12
-
Stefan Neufeind uploaded patch set 2 12/12/11, 12:57
-
Stefan Neufeind commented on patch set 2 12/12/11, 12:57
Looks good to me, but someone else must approve just added typehint pointed out by Xavier. rest looks okay imho. 2x +1 from Helmut still apply -
Oliver Hader uploaded patch set 3 12/12/11, 12:57
-
Oliver Hader commented on patch set 3 12/12/11, 12:57
Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> -
Xavier Perseguers commented on patch set 1 12/12/11, 12:57
(1 inline comment)index.php:92missing 'array' type hint -
Helmut Hummel commented on patch set 1 12/12/11, 12:57
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 V 0 12/12/11, 12:57
by team member; Looks good to me, approved Reviews complete together with Helumts review of patch Set #1, only the array type hinting changed meanwhile. Merged. -
Steffen Ritter commented on patch set 3 12/12/11, 12:57
Verified; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 12/12/11, 12:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2312/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/12/11, 12:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2463/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/12/11, 12:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2663/ : SUCCESS -
Christian Kuhn merged patch set 3 12/12/11, 12:57