63383[BUGFIX] Remove undefined variable in QueryGenerator
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Georg Ringer +1
- Oli Bartsch +1
- Oliver Klee +1
- Ingo Fabbri +1
-
Verified V +2 Done
- Susi Moog +2
- Georg Ringer +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1012
-
Daniel Goerz uploaded patch set 1 02/22/20, 21:27
-
Benjamin Kott commented on patch set 1 CR -1 02/22/20, 21:29
only variable should beQueryGenerator.php:1006only variable should be removed not the outer div -
Daniel Goerz commented on patch set 1 02/22/20, 21:31
QueryGenerator.php:1006Reply UnresolvedThat makes a lot of sense :D -
Daniel Goerz commented on patch set 2 02/22/20, 21:33
Published edit on patch set 1. -
Oli Bartsch voted on patch set 2 V +1 CR +1 02/22/20, 21:42
-
Georg Ringer voted on patch set 2 V +1 CR +1 02/22/20, 22:03
-
TYPO3com voted on patch set 1 V +1 02/22/20, 22:06 Completed build in 25m 19s on Sat, 22 Feb, 10:06 PM Test Summary: 71580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-518
-
TYPO3com voted on patch set 2 V +1 02/22/20, 22:12 Completed build in 31m 31s on Sat, 22 Feb, 10:12 PM Test Summary: 71580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-520
-
Ingo Fabbri voted on patch set 2 CR +1 02/22/20, 23:09
-
Oliver Klee voted on patch set 2 CR +1 02/22/20, 23:45
-
Susi Moog voted on patch set 2 V +2 CR +2 02/23/20, 09:56
-
Susi Moog merged patch set 3 02/23/20, 09:56