Review main Merged

63386[DOCS] Add missing key for widget registration

Oli Bartsch CR +2 V +2 Easy +2 −0 updated 02/23/20, 08:03

Commit message

Using the example registration of a custom widget would lead
to an ArgumentCountError respectively an RuntimeException as
the `arguments` key is missing. Therefore the key is added to
the configuration examples.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 02/23/20, 02:48

  2. TYPO3com voted on patch set 1 V +1 02/23/20, 03:01 Completed build in 13m 01s on Sun, 23 Feb, 03:01 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-527

  3. Oli Bartsch uploaded patch set 2 02/23/20, 03:06

  4. TYPO3com voted on patch set 2 V +1 02/23/20, 03:34 Completed build in 26m 20s on Sun, 23 Feb, 03:34 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-528

  5. Björn Jacob voted on patch set 2 V +1 CR +1 02/23/20, 07:23

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 02/23/20, 08:03

  7. Daniel Goerz merged patch set 3 02/23/20, 08:03