Review main Merged

63389[FEATURE] Allow PageContentErrorHandler to resolve pages with sub requests

Christian Eßl CR +2 V +2 Normal +89 −41 updated 02/24/20, 20:14

Commit message

The PageContentErrorHandler provided by the core can take in either a
URL or a page uid for resolving an error page in the frontend. In both
cases, the class would then start a Guzzle/cURL request to fetch the
error page content.
This has now been changed for internal pages, where a page uid has been
given. In this case, the PageContentErrorHandler will now dispatch an
internal SubRequest instead, to avoid an unnecessary cURL call.

In staging environments, the website would often be access protected
with basic auth options (for example a .htpasswd auth file on Apache
Webservers). In such a case, error pages with the default
PageContentErrorHandler would have failed before, as the internal cURL
call for fetching the error page was lacking these required basic auth
options.
For internal pages, a sub request is now used, bypassing the need for
an external cURL call.

This solution is mostly based on Benni Mack's
LocalPageContentErrorHandler with his approval.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Björn Jacob +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1622

  1. Christian Eßl uploaded patch set 1 02/23/20, 09:40

  2. TYPO3com voted on patch set 1 V -1 02/23/20, 09:41 Completed build in 21s on Sun, 23 Feb, 09:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-534

  3. Christian Eßl uploaded patch set 2 02/23/20, 09:41

  4. TYPO3com voted on patch set 2 V +1 02/23/20, 09:55 Completed build in 13m 26s on Sun, 23 Feb, 09:55 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-535

  5. Christian Eßl updated the commit message in patch set 3 02/23/20, 10:30

  6. Björn Jacob commented on patch set 3 CR -1 02/23/20, 10:42

    Thank you very much for this great improvement. Already loving it! Please also adapt the rst file based on my review of the commit message.
    Wouldn't "Allow" be the better term?
    * no comma after "core" * it is "a URL" not "an" -> https://www.quora.com/Which-is-correct-A-URL-or-An-URL
    This sentence is very difficult to understand. Could you split it in 2 or 3 easier sentences?

    Unresolved

    Mack's
  7. TYPO3com voted on patch set 3 V +1 02/23/20, 10:45 Completed build in 15m 35s on Sun, 23 Feb, 10:45 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-537

  8. Christian Eßl uploaded patch set 4 02/23/20, 11:27

  9. Christian Eßl commented on patch set 4 02/23/20, 11:27

    Reply

    Done

    Reply

    Done

    Reply

    Done
  10. Björn Jacob updated the commit message in patch set 5 02/23/20, 11:32

  11. Björn Jacob commented on patch set 5 02/23/20, 11:33

    Thanks Christian! I have adapted the commit msg. I hope you don't mind :)
  12. Björn Jacob commented on patch set 6 02/23/20, 11:33

    Published edit on patch set 5.
  13. Björn Jacob voted on patch set 6 CR +1 02/23/20, 11:34

  14. TYPO3com voted on patch set 4 V +1 02/23/20, 11:40 Completed build in 13m 40s on Sun, 23 Feb, 11:40 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-544

  15. TYPO3com voted on patch set 5 V +1 02/23/20, 11:54 Completed build in 16m 14s on Sun, 23 Feb, 11:54 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-546

  16. TYPO3com voted on patch set 6 V +1 02/23/20, 12:01 Completed build in 22m 40s on Sun, 23 Feb, 12:01 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-547

  17. Susi Moog voted on patch set 6 CR +1 02/24/20, 07:24

  18. Susi Moog voted on patch set 6 V +1 02/24/20, 07:30

  19. Georg Ringer voted on patch set 6 V +2 CR +2 02/24/20, 08:05

  20. Georg Ringer merged patch set 7 02/24/20, 08:05

  21. Susi Moog wrote 02/24/20, 18:19

    Created a revert of this change as I9f6f5155a78e7d515107f8b6b8d16dc55b78b7dd
  22. Anja Leichsenring commented on patch set 7 02/24/20, 20:14