63389[FEATURE] Allow PageContentErrorHandler to resolve pages with sub requests
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Björn Jacob +1
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1622
-
Christian Eßl uploaded patch set 1 02/23/20, 09:40
-
TYPO3com voted on patch set 1 V -1 02/23/20, 09:41 Completed build in 21s on Sun, 23 Feb, 09:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-534
-
Christian Eßl uploaded patch set 2 02/23/20, 09:41
-
TYPO3com voted on patch set 2 V +1 02/23/20, 09:55 Completed build in 13m 26s on Sun, 23 Feb, 09:55 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-535
-
Christian Eßl updated the commit message in patch set 3 02/23/20, 10:30
-
Björn Jacob commented on patch set 3 CR -1 02/23/20, 10:42
Thank you very much for this great improvement. Already loving it! Please also adapt the rst file based on my review of the commit message.Wouldn't "Allow" be the better term?* no comma after "core" * it is "a URL" not "an" -> https://www.quora.com/Which-is-correct-A-URL-or-An-URLThis sentence is very difficult to understand. Could you split it in 2 or 3 easier sentences?Unresolved
Mack's -
TYPO3com voted on patch set 3 V +1 02/23/20, 10:45 Completed build in 15m 35s on Sun, 23 Feb, 10:45 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-537
-
Christian Eßl uploaded patch set 4 02/23/20, 11:27
-
Björn Jacob updated the commit message in patch set 5 02/23/20, 11:32
-
Björn Jacob commented on patch set 5 02/23/20, 11:33
Thanks Christian! I have adapted the commit msg. I hope you don't mind :) -
Björn Jacob commented on patch set 6 02/23/20, 11:33
Published edit on patch set 5. -
Björn Jacob voted on patch set 6 CR +1 02/23/20, 11:34
-
TYPO3com voted on patch set 4 V +1 02/23/20, 11:40 Completed build in 13m 40s on Sun, 23 Feb, 11:40 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-544
-
TYPO3com voted on patch set 5 V +1 02/23/20, 11:54 Completed build in 16m 14s on Sun, 23 Feb, 11:54 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-546
-
TYPO3com voted on patch set 6 V +1 02/23/20, 12:01 Completed build in 22m 40s on Sun, 23 Feb, 12:01 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-547
-
Susi Moog voted on patch set 6 CR +1 02/24/20, 07:24
-
Susi Moog voted on patch set 6 V +1 02/24/20, 07:30
-
Georg Ringer voted on patch set 6 V +2 CR +2 02/24/20, 08:05
-
Georg Ringer merged patch set 7 02/24/20, 08:05
-
Susi Moog wrote 02/24/20, 18:19
Created a revert of this change as I9f6f5155a78e7d515107f8b6b8d16dc55b78b7dd -
Anja Leichsenring commented on patch set 7 02/24/20, 20:14
was reverted by https://review.typo3.org/c/Packages/TYPO3.CMS/+/63308/