Review main Merged

63390[BUGFIX] Fix page module button label and undefined variable access

Claus Due CR +2 V +2 Easy +11 −8 updated 02/24/20, 12:54

Commit message

Fixes a couple of issues:

* Missing button text for "new content" button
* Two cases of access to undefined variables
* Add missing f:format.raw in record footer
* Add missing paste-after icon

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Kevin Appelt +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Kevin Appelt +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1014

  1. Claus Due uploaded patch set 1 02/23/20, 10:36

  2. TYPO3com voted on patch set 1 V +1 02/23/20, 11:04 Completed build in 28m 17s on Sun, 23 Feb, 11:04 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-540

  3. Kevin Appelt uploaded patch set 2 02/23/20, 13:50

  4. TYPO3com voted on patch set 2 V +1 02/23/20, 14:05 Completed build in 14m 21s on Sun, 23 Feb, 02:05 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-554

  5. Kevin Appelt voted on patch set 2 V +1 CR +1 02/23/20, 14:40

  6. Oli Bartsch voted on patch set 2 CR +1 02/23/20, 20:57

  7. Claus Due uploaded patch set 3 02/23/20, 21:43

  8. TYPO3com voted on patch set 3 V -1 02/23/20, 22:00 Completed build in 15m 52s on Sun, 23 Feb, 10:00 PM Test Summary: 71585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-591

  9. TYPO3com voted on patch set 3 V +1 02/23/20, 22:27 Completed build in 17m 22s on Sun, 23 Feb, 10:27 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-593

  10. Christian Eßl voted on patch set 3 CR +1 02/24/20, 06:46

  11. Oli Bartsch voted on patch set 3 CR +1 02/24/20, 07:18

  12. Kevin Appelt voted on patch set 3 V +1 CR +1 02/24/20, 12:40

  13. Georg Ringer voted on patch set 3 V +2 CR +2 02/24/20, 12:54

  14. Georg Ringer merged patch set 4 02/24/20, 12:54