63392[FEATURE] Widget to show pages without meta description
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 9
- Build/Sources/Sass/dashboard/_widget_table.scss+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-90333-Dashboard.rst+1 −0
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+1 −1
- typo3/sysext/seo/Classes/Widgets/PagesWithoutMetaDescriptionWidget.php5new+87 −0
- typo3/sysext/seo/Configuration/Backend/DashboardWidgetGroups.phpnew+6 −0
- typo3/sysext/seo/Configuration/Services.yaml1+7 −0
- typo3/sysext/seo/Resources/Private/Language/locallang.xlf2new+17 −0
- typo3/sysext/seo/Resources/Private/Templates/Dashboard/Widget/PagesWithoutMetaDescription.htmlnew+25 −0
- typo3/sysext/seo/ext_localconf.php3+2 −0
Review log 2027
Show 2 earlier messages
-
Richard Haeser uploaded patch set 3 02/23/20, 11:54
-
TYPO3com voted on patch set 1 V +1 02/23/20, 12:25 Completed build in 22m 02s on Sun, 23 Feb, 12:25 PM Test Summary: 71584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-550
-
TYPO3com voted on patch set 2 V +1 02/23/20, 12:25 Completed build in 22m 03s on Sun, 23 Feb, 12:25 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-551
-
TYPO3com voted on patch set 3 V +1 02/23/20, 12:30 Completed build in 27m 49s on Sun, 23 Feb, 12:30 PM Test Summary: 71585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-552
-
Koen Wouters voted on patch set 3 V +1 CR +1 02/23/20, 14:46
-
Oli Bartsch commented on patch set 3 CR -1 02/23/20, 17:58
PagesWithoutMetaDescriptionWidget.php:13UnresolvedCould we also provide a `description` as all other widgets contain one. Looks a bit wrong in the wizard IMO.Services.yaml:28UnresolvedIf think we should use the newly created `seo` group here.locallang.xlf:12UnresolvedThis is currently not used.locallang.xlf:15UnresolvedThis is currently not used. -
Richard Haeser uploaded patch set 4 02/24/20, 12:58
-
Richard Haeser uploaded patch set 5 02/24/20, 13:06
-
Markus Klein commented on patch set 5 V -1 CR -1 02/24/20, 13:13
User permissions must be validated. Otherwise we introduce a security flaw -
Richard Haeser uploaded patch set 6 02/24/20, 13:28
-
Georg Ringer commented on patch set 6 CR -1 02/24/20, 13:30
ext_localconf.php:29we should then define that all up to 100 is internal! -
TYPO3com voted on patch set 4 V +1 02/24/20, 13:34 Completed build in 35m 03s on Mon, 24 Feb, 01:34 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-622
-
Richard Haeser commented on patch set 6 02/24/20, 13:52
ext_localconf.php:29ReplyThat's a good one. Where do we want to document this? Only in the feature RST? -
TYPO3com voted on patch set 5 V -1 02/24/20, 13:52 Completed build in 27m 52s on Mon, 24 Feb, 01:52 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-623
-
Richard Haeser commented on patch set 6 02/24/20, 14:04
ext_localconf.php:29Reply UnresolvedI think this should be in https://review.typo3.org/c/Packages/TYPO3.CMS/+/63398. Georg can you live with it to document it in that patch? -
Richard Haeser uploaded patch set 7 02/24/20, 14:05
-
Georg Ringer commented on patch set 7 02/24/20, 14:08
@richard: yes that's ok but as said, everything below 100 should be fore core only -
TYPO3com voted on patch set 6 V -1 02/24/20, 14:11 Completed build in 16m 02s on Mon, 24 Feb, 02:11 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-626
-
Georg Ringer commented on patch set 7 CR -1 02/24/20, 14:24
PagesWithoutMetaDescriptionWidget.php:59Unresolvedthis limit is now a soft limit as the checks done are later. this might lead to the state that the 1st 100 rows are still not allowed for an editor and the widget will be empty. -
TYPO3com voted on patch set 7 V +1 02/24/20, 14:29 Completed build in 21m 47s on Mon, 24 Feb, 02:29 PM Test Summary: 71649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-629
-
Daniel Siepmann commented on patch set 7 02/25/20, 16:24
PagesWithoutMetaDescriptionWidget.php:45Not sure about that one. People might add custom doktypes. So this will give a different UX. I won't expect this option to be configurable right now, just want to raise this issue. Would be ok to have an follow up task at forge regarding configuration of widgets. Custom doktypes might be needed to be excluded or included. -
Oli Bartsch commented on patch set 7 02/25/20, 17:29
PagesWithoutMetaDescriptionWidget.php:45Reply UnresolvedConfiguration of the widgets is planed if I understood Richard right but won’t make it in v10 as this would also be a FEATURE. So maybe we should change this to `allowedDoktypes` to ensure not break something with custom ones. When people than add custom doktypes they can still add an own widget and override the array. -
Richard Haeser commented on patch set 7 CR -1 02/25/20, 18:27
Will come back to this after my holiday. About config: There is a difference between user settings (that will not make it) and to configure the behavior of a widget for all users. -
Susi Moog commented on patch set 7 02/28/20, 06:41
What do you think about abandoning this change in favor of the widget library approach currently discussed in #cig-dashboard? -
Richard Haeser abandoned the change 03/25/20, 13:21
For now, we don't accept new widgets for dashboard in core for v10. Widgets that can be in core, but didn't make it before feature freeze, can be added to a separate package. If you think this is a good widget, please add the request (and pull request) to https://github.com/FriendsOfTYPO3/widgets. This patch is abandoned for now.
PagesWithoutMetaDescriptionWidget.php:10Unresolved