Review main Merged

63393[TASK] Move Changelog files into 10.3 folder

Anja Leichsenring CR +2 V +2 Expert +867 −756 updated 02/25/20, 08:58

Commit message

The upcoming release of TYPO3 10.3 requires all documentation to
be placed into the version folder.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Björn Jacob +1

Issues 1

Files 86

Show 66 more files

Review log 2739

Show 914 earlier messages
  1. Anja Leichsenring uploaded patch set 1 02/23/20, 13:57

  2. Anja Leichsenring uploaded patch set 2 02/23/20, 14:03

  3. TYPO3com voted on patch set 1 V -1 02/23/20, 14:25 Completed build in 22m 52s on Sun, 23 Feb, 02:25 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-557

  4. TYPO3com voted on patch set 2 V -1 02/23/20, 14:31 Completed build in 16m 21s on Sun, 23 Feb, 02:31 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-558

  5. Anja Leichsenring uploaded patch set 3 02/23/20, 14:41

  6. Anja Leichsenring uploaded patch set 4 02/23/20, 14:48

  7. TYPO3com voted on patch set 3 V -1 02/23/20, 15:09 Completed build in 22m 23s on Sun, 23 Feb, 03:09 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-564

  8. TYPO3com voted on patch set 4 V +1 02/23/20, 15:22 Completed build in 16m 50s on Sun, 23 Feb, 03:22 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-566

  9. Björn Jacob commented on patch set 4 02/24/20, 12:44

    42 of 80 checked.

    Deprecation-89463-SwitchableControllerActions.rst:15

    Do we spell it "TypoScript"?

    Deprecation-89463-SwitchableControllerActions.rst:47

    comma after "Unfortunately"

    Deprecation-90249-PackageRelatedSignalSlotsMigratedToPSR-14Events.rst:24

    Add additional newline.

    Deprecation-90258-SimplifiedRTEParserAPI.rst:20

    Add additional newline.

    Deprecation-90348-PageLayoutViewClass.rst:32

    Maybe add "#" to indicate it is an issue number.

    Feature-87072-AddedConfigurationOptionsForLockingAddedConfigurationOptionsForLocking.rst:49

    "exercised" is the better word here.

    Feature-89139-AddDependencyInjectionSupportForConsoleCommands.rst:27

    superfluous "has"

    Feature-89551-AddFluidAdditionalAttributesToTheFormElement.rst:12

    "within a form element:"

    Feature-89644-AddOptionalArgumentFieldsToEditRecordViewHelpers.rst:25

    This sentence has a problem grammar-wise. IMHO it is "already exists". Maybe this is better: The functionality for :html:`columnsOnly` has always been there for the backend route `/record/edit` even before this patch.

    Feature-90042-SpecialPageIconsCustomizableByDoktype.rst:35

    "Icons you don't provide will automatically fall back to the variant for regular page doktypes."
  10. Björn Jacob voted on patch set 4 CR -1 02/24/20, 12:44

  11. Anja Leichsenring uploaded patch set 5 02/24/20, 17:29

  12. Anja Leichsenring commented on patch set 5 02/24/20, 17:30

    Deprecation-89463-SwitchableControllerActions.rst:15 Reply

    Done

    Deprecation-89463-SwitchableControllerActions.rst:47 Reply

    Done

    Deprecation-90249-PackageRelatedSignalSlotsMigratedToPSR-14Events.rst:24 Reply

    Done

    Deprecation-90258-SimplifiedRTEParserAPI.rst:20 Reply

    Done

    Deprecation-90348-PageLayoutViewClass.rst:32 Reply

    Done

    Feature-87072-AddedConfigurationOptionsForLockingAddedConfigurationOptionsForLocking.rst:49 Reply

    Done

    Feature-89139-AddDependencyInjectionSupportForConsoleCommands.rst:27 Reply

    Done

    Feature-89551-AddFluidAdditionalAttributesToTheFormElement.rst:12 Reply

    Done

    Feature-89644-AddOptionalArgumentFieldsToEditRecordViewHelpers.rst:25 Reply

    Done

    Feature-90042-SpecialPageIconsCustomizableByDoktype.rst:35 Reply

    Done
  13. TYPO3com voted on patch set 5 V +1 02/24/20, 17:46 Completed build in 16m 42s on Mon, 24 Feb, 05:46 PM Test Summary: 71649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-640

  14. Anja Leichsenring uploaded patch set 6 02/24/20, 20:26

  1. TYPO3com voted on patch set 6 V +1 02/24/20, 20:47 Completed build in 19m 00s on Mon, 24 Feb, 08:47 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-651

  2. Georg Ringer commented on patch set 6 CR -1 02/24/20, 21:18

    Deprecation-90348-PageLayoutViewClass.rst:26

    not true anymore, https://review.typo3.org/c/Packages/TYPO3.CMS/+/50389 is currently readding those hooks to be compatible
  3. Anja Leichsenring commented on patch set 6 02/25/20, 06:26

    Deprecation-90348-PageLayoutViewClass.rst:26 Reply Unresolved

    it is not merged yet, so the adjustment of this very part is not available yet.
  4. Anja Leichsenring uploaded patch set 7 02/25/20, 06:33

  5. Björn Jacob commented on patch set 8 02/25/20, 06:52

    Published edit on patch set 7.
  6. TYPO3com voted on patch set 7 V +1 02/25/20, 07:00 Completed build in 18m 25s on Tue, 25 Feb, 07:00 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-672

  7. Björn Jacob commented on patch set 9 02/25/20, 07:05

    Published edit on patch set 8.
  8. TYPO3com voted on patch set 8 V -1 02/25/20, 07:07 Completed build in 15m 36s on Tue, 25 Feb, 07:07 AM Test Summary: 71672 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-673

  9. TYPO3com voted on patch set 9 V -1 02/25/20, 07:08 Completed build in 27s on Tue, 25 Feb, 07:08 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-675

  10. Oli Bartsch commented on patch set 9 02/25/20, 07:21

    Deprecation-89463-SwitchableControllerActions.rst:15 Unresolved

    Should we unify the vase here? Sometimes the first char is Capitalized sometimes not.

    Important-90371-TypoScriptOptionConfigcontent_from_pid_allowOutsideDomainRemoved.rst:12

    Maybe remove this.
  11. Anja Leichsenring uploaded patch set 10 02/25/20, 07:22

  12. Björn Jacob commented on patch set 11 02/25/20, 07:32

    Published edit on patch set 10.
  13. Björn Jacob commented on patch set 11 CR -1 02/25/20, 07:45

    On it.

    Feature-78450-IntroducePreviewRendererPattern.rst:13 Unresolved

    "activated"

    Feature-78450-IntroducePreviewRendererPattern.rst:61 Unresolved

    "The class shown is the standard implementation TYPO3 provides. Inspect this class for further developer information."

    Feature-78450-IntroducePreviewRendererPattern.rst:63 Unresolved

    "overridden, "

    Feature-78450-IntroducePreviewRendererPattern.rst:65 Unresolved

    "Individual preview"

    Feature-78450-IntroducePreviewRendererPattern.rst:65 Unresolved

    "by using"

    Feature-78450-IntroducePreviewRendererPattern.rst:72 Unresolved

    This specifies the PreviewRenderer to be used for any record in :php:`$table`.

    Feature-78450-IntroducePreviewRendererPattern.rst:80 Unresolved

    "This specifies the PreviewRenderer only for records of type :php:`$type` as determined by the type field of your table."

    Feature-78450-IntroducePreviewRendererPattern.rst:94 Unresolved

    "The recommended"

    Feature-78450-IntroducePreviewRendererPattern.rst:113 Unresolved

    "instance of"

    Feature-90136-ShowApplicationContextInTheEnvironmentModule.rst:19 Unresolved

    "Administrators"

    Feature-90249-NewPSR-14EventsForExistingPackage-relatedSignalSlots.rst:12 Unresolved

    "TYPO3 extensions"

    Feature-90266-Fluid-basedTemplatedEmails.rst:38 Unresolved

    "if set"

    Feature-90267-CustomPlaceholderProcessingInSiteConfig.rst:43 Unresolved

    ":"

    Feature-90267-CustomPlaceholderProcessingInSiteConfig.rst:68 Unresolved

    "site configuration:"

    Feature-90267-CustomPlaceholderProcessingInSiteConfig.rst:76 Unresolved

    "cannot"

    Feature-90298-ImproveUserInfoInBeuserModule.rst:16 Unresolved

    "an assigned"

    Feature-90333-Dashboard.rst:59 Unresolved

    "providing"
  14. TYPO3com voted on patch set 10 V +1 02/25/20, 08:01 Completed build in 37m 03s on Tue, 25 Feb, 08:01 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-679

  15. Björn Jacob commented on patch set 11 02/25/20, 08:08

    Feature-90068-ImplementBetterFileDumpController.rst:18 Unresolved

    "a UID"

    Feature-90068-ImplementBetterFileDumpController.rst:19 Unresolved

    "a UID"

    Feature-90068-ImplementBetterFileDumpController.rst:20 Unresolved

    "a UID"

    Feature-90068-ImplementBetterFileDumpController.rst:21 Unresolved

    "a UID"

    Feature-90068-ImplementBetterFileDumpController.rst:31 Unresolved

    "See the following example on how to create a URI using the :php:`FileDumpController` for"

    Feature-90068-ImplementBetterFileDumpController.rst:58 Unresolved

    "This example shows the usage how to create a URI to load an image of"

    Feature-90234-IntroduceCacheHashConfigurationAndMatchingIndicators.rst:51 Unresolved

    "overcomes the previous necessity to explicitly state all parameter names to be"

    Feature-90234-IntroduceCacheHashConfigurationAndMatchingIndicators.rst:66 Unresolved

    "partial matches allow to simplify the configuration and consider all items having"

    Feature-90234-IntroduceCacheHashConfigurationAndMatchingIndicators.rst:76 Unresolved

    "The present configuration for the :php:`cHash` section is still supported - there is"

    Feature-90411-HTML-basedWorkspaceNotificationEmailsOnStageChange.rst:20 Unresolved

    "those"

    Feature-90416-SpecificTargetFileExtensionInImage-relatedViewHelpers.rst:4 Unresolved

    "image"

    Feature-90416-SpecificTargetFileExtensionInImage-relatedViewHelpers.rst:12 Unresolved

    "core's"

    Feature-90425-AddSeoFieldsToInfoModule.rst:4 Unresolved

    "SEO"

    Feature-90426-Browser-nativeLazyLoadingForImages.rst:16 Unresolved

    "viewport"

    Important-89992-UseNewTranslationServer.rst:28 Unresolved

    Remove "again".
  16. Björn Jacob commented on patch set 11 V +1 CR +1 02/25/20, 08:16

    I am done so far :) Resolved one of Oliver's findings and all of mine.

    Important-90371-TypoScriptOptionConfigcontent_from_pid_allowOutsideDomainRemoved.rst:12 Reply

    Done
  17. Björn Jacob commented on patch set 12 02/25/20, 08:16

    Published edit on patch set 11.
  18. Björn Jacob voted on patch set 12 V +1 CR +1 02/25/20, 08:16

  19. Daniel Goerz voted on patch set 12 V +1 02/25/20, 08:25

  20. Oliver Hader voted on patch set 12 CR +1 02/25/20, 08:36

  21. Oli Bartsch voted on patch set 12 V +1 CR +1 02/25/20, 08:38

  22. TYPO3com voted on patch set 11 V +1 02/25/20, 08:52 Completed build in 54m 39s on Tue, 25 Feb, 08:52 AM Test Summary: 71996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-682

  23. Oliver Hader voted on patch set 12 V +2 CR +2 02/25/20, 08:58

  24. Oliver Hader merged patch set 13 02/25/20, 08:58

  25. TYPO3com voted on patch set 12 V +1 02/25/20, 08:58 Completed build in 33m 18s on Tue, 25 Feb, 08:58 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-683