Review main Abandoned

63395[WIP][FEATURE] TYPO3 version widget

Koen Wouters CR 0 V 0 Normal +54 −11 updated 03/09/20, 07:53

Commit message

A new widget is added which displays the current TYPO3 version
status.

TODO: Styling text in widget (green, orange, red).
Hide button when no link is added, use Typo3VersionMessage
function to show version texts.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 67

  1. Koen Wouters uploaded patch set 1 02/23/20, 15:16

  2. TYPO3com voted on patch set 1 V +1 02/23/20, 15:35 Completed build in 15m 53s on Sun, 23 Feb, 03:35 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-569

  3. Benni Mack commented on patch set 1 02/27/20, 11:33

    so you're saying - a widget is telling me which version of TYPO3 is currently running? We do have three other places in TYPO3 Backend showing this information already: - <title> tag of Backend - Header bar in Backend - SystemInformation Toolbar Item
  4. Koen Wouters commented on patch set 1 02/27/20, 12:33

    > Patch Set 1: > > so you're saying - a widget is telling me which version of TYPO3 is currently running? > > We do have three other places in TYPO3 Backend showing this information already: > - <title> tag of Backend > - Header bar in Backend > - SystemInformation Toolbar Item This widget should show your current TYPO3 version and if your TYPO3 version is up to date. When there is a security update the widget will warn users with a red color in the widget, so they don't have to open the system information dropdown.
  5. Georg Ringer commented on patch set 1 02/27/20, 12:35

    > This widget should show your current TYPO3 version and if your TYPO3 version is up to date. When there is a security update the widget will warn users with a red color in the widget, so they don't have to open the system information dropdown. Please just do 1 widget which covers all reports and give feedback if something should be done. no need to do everything twice
  6. Richard Haeser commented on patch set 1 V -1 03/09/20, 07:53

    For now, we don't accept new widgets for dashboard in core for v10. Widgets that can be in core, but didn't make it before feature freeze, can be added to a separate package. If you think this is a good widget, please add the request (and pull request) to https://github.com/FriendsOfTYPO3/widgets. I will abandon this review for now.
  7. Richard Haeser abandoned the change 03/09/20, 07:53