Review main Merged

63397[FEATURE] Dashboard widget: TYPO3 security advisories

Oli Bartsch CR +2 V +2 Easy +49 −0 updated 02/24/20, 19:41

Commit message

A new widget is added which displays a list of security
advisories from the typo3.org RSS feed.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Kay Strobach +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
    • Kay Strobach +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2430

Show 35 earlier messages
  1. Oli Bartsch uploaded patch set 1 02/23/20, 17:31

  2. Oli Bartsch uploaded patch set 2 02/23/20, 17:32

  3. TYPO3com voted on patch set 1 V +1 02/23/20, 17:46 Completed build in 14m 58s on Sun, 23 Feb, 05:46 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-576

  4. TYPO3com voted on patch set 2 V +1 02/23/20, 17:52 Completed build in 15m 29s on Sun, 23 Feb, 05:52 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-577

  5. Kay Strobach commented on patch set 2 CR -1 02/24/20, 07:02

    Thank you for your contribution I'd vote for a mininal wording change this should not be called news, but security advisories or security bulletins. Maybe a natvie speaker can help out here.

    Feature-90333-Dashboard.rst:34 Unresolved

    TYPO3 security Bulletins OR TYPO3 security Advisories

    T3SecurityNewsWidget.php:22 Unresolved

    I would opt for Bulletins or Advisories instead of news ...

    locallang.xlf:165 Unresolved

    TYPO3 security Bulletins OR TYPO3 security Advisories

    locallang.xlf:168 Unresolved

    same wording issue here

    locallang.xlf:171 Unresolved

    More TYPO3 security Bulletins OR More TYPO3 security Advisories
  1. Oli Bartsch commented on patch set 2 02/24/20, 07:46

    > Patch Set 2: Code-Review-1 > > (5 comments) > > Thank you for your contribution > > I'd vote for a mininal wording change this should not be called news, but security advisories or security bulletins. Maybe a natvie speaker can help out here. I will call it "advisories" as this term is also used at typo3.org
  2. Kay Strobach commented on patch set 2 02/24/20, 07:49

    > Patch Set 2: > > > Patch Set 2: Code-Review-1 > > > > (5 comments) > > > > Thank you for your contribution > > > > I'd vote for a mininal wording change this should not be called news, but security advisories or security bulletins. Maybe a natvie speaker can help out here. > > I will call it "advisories" as this term is also used at typo3.org Thank you, will review the next iteration then :D
  3. Oli Bartsch uploaded patch set 3 02/24/20, 07:55

  4. Oli Bartsch updated the commit message in patch set 4 02/24/20, 07:56

  5. Oli Bartsch uploaded patch set 5 02/24/20, 07:59

  6. Kay Strobach commented on patch set 5 V +1 CR +1 02/24/20, 08:08

    nice - thanks a lot
  7. TYPO3com voted on patch set 3 V +1 02/24/20, 08:13 Completed build in 18m 21s on Mon, 24 Feb, 08:13 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-596

  8. TYPO3com voted on patch set 4 V +1 02/24/20, 08:20 Completed build in 16m 40s on Mon, 24 Feb, 08:20 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-597

  9. Koen Wouters voted on patch set 5 V +1 CR +1 02/24/20, 08:24

  10. TYPO3com voted on patch set 5 V +1 02/24/20, 08:27 Completed build in 23m 29s on Mon, 24 Feb, 08:27 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-598

  11. Richard Haeser uploaded patch set 6 02/24/20, 12:40

  12. Richard Haeser voted on patch set 6 V +1 CR +1 02/24/20, 12:40

  13. TYPO3com voted on patch set 6 V +1 02/24/20, 13:02 Completed build in 21m 18s on Mon, 24 Feb, 01:02 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-617

  14. Daniel Siepmann commented on patch set 6 02/24/20, 13:14

    T3SecurityAdvisoriesWidget.php:28

    Shouldn't this be updated in `AbstractRssWidget` and not be overwritten? Should be the default one I guess?
  15. Georg Ringer voted on patch set 6 V +1 02/24/20, 13:15

  16. Kay Strobach commented on patch set 6 02/24/20, 13:28

    ok, question is simply custom icon or no custom icon ...

    T3SecurityAdvisoriesWidget.php:28 Reply

    i think there should be a new icon for the advisories
  17. Oli Bartsch commented on patch set 6 02/24/20, 16:05

    T3SecurityAdvisoriesWidget.php:28 Reply

    @Daniel I'm not quite sure how this was intended by Richard. @Kay surely we could add a new icon here. But I'm not aware of the icon set and who is responsible for creating them. IMO this should not block this one to get merged before feature freeze. Let's do this afterwards with a small TASK patch. What do you think?
  18. Benjamin Kott commented on patch set 6 02/24/20, 16:06

    T3SecurityAdvisoriesWidget.php:28 Reply

    it´s an rss widget - please use the rss icon.
  19. Oli Bartsch commented on patch set 6 02/24/20, 16:09

    T3SecurityAdvisoriesWidget.php:28 Reply

    So you are fine with the `content-widget-rss` as this is also used for the t3newsWidget? Or should I use the `dashboard-rss` icon defined in the Abstract class?
  20. Benjamin Kott commented on patch set 6 02/24/20, 16:13

    T3SecurityAdvisoriesWidget.php:28 Reply

    there should be no dashboard-rss icon at all. if it´s still defined as such, its a bug. all icons have been moved to content-dashboard* / content-widget*
  21. Oli Bartsch commented on patch set 6 02/24/20, 16:15

    T3SecurityAdvisoriesWidget.php:28 Reply

    Oke so the icon here is right. Just the icon in the abstract class is false. This should be fixed in separate Patch. Is this oke for you?
  22. Oli Bartsch commented on patch set 6 02/24/20, 16:39

    T3SecurityAdvisoriesWidget.php:28 Reply

    Done
  23. Kay Strobach voted on patch set 6 V +1 CR +1 02/24/20, 18:00

  24. Richard Haeser voted on patch set 6 V +2 CR +2 02/24/20, 19:41

  25. Richard Haeser merged patch set 7 02/24/20, 19:41