63397[FEATURE] Dashboard widget: TYPO3 security advisories
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Kay Strobach +1
-
Verified V +2 Done
- Richard Haeser +2
- Georg Ringer +1
- Kay Strobach +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2430
Show 35 earlier messages
-
Oli Bartsch uploaded patch set 1 02/23/20, 17:31
-
Oli Bartsch uploaded patch set 2 02/23/20, 17:32
-
TYPO3com voted on patch set 1 V +1 02/23/20, 17:46 Completed build in 14m 58s on Sun, 23 Feb, 05:46 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-576
-
TYPO3com voted on patch set 2 V +1 02/23/20, 17:52 Completed build in 15m 29s on Sun, 23 Feb, 05:52 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-577
-
Kay Strobach commented on patch set 2 CR -1 02/24/20, 07:02
Thank you for your contribution I'd vote for a mininal wording change this should not be called news, but security advisories or security bulletins. Maybe a natvie speaker can help out here.Feature-90333-Dashboard.rst:34UnresolvedTYPO3 security Bulletins OR TYPO3 security AdvisoriesT3SecurityNewsWidget.php:22UnresolvedI would opt for Bulletins or Advisories instead of news ...locallang.xlf:165UnresolvedTYPO3 security Bulletins OR TYPO3 security Advisorieslocallang.xlf:168Unresolvedsame wording issue herelocallang.xlf:171UnresolvedMore TYPO3 security Bulletins OR More TYPO3 security Advisories
-
Oli Bartsch commented on patch set 2 02/24/20, 07:46
> Patch Set 2: Code-Review-1 > > (5 comments) > > Thank you for your contribution > > I'd vote for a mininal wording change this should not be called news, but security advisories or security bulletins. Maybe a natvie speaker can help out here. I will call it "advisories" as this term is also used at typo3.org -
Kay Strobach commented on patch set 2 02/24/20, 07:49
> Patch Set 2: > > > Patch Set 2: Code-Review-1 > > > > (5 comments) > > > > Thank you for your contribution > > > > I'd vote for a mininal wording change this should not be called news, but security advisories or security bulletins. Maybe a natvie speaker can help out here. > > I will call it "advisories" as this term is also used at typo3.org Thank you, will review the next iteration then :D -
Oli Bartsch uploaded patch set 3 02/24/20, 07:55
-
Oli Bartsch updated the commit message in patch set 4 02/24/20, 07:56
-
Oli Bartsch uploaded patch set 5 02/24/20, 07:59
-
Kay Strobach commented on patch set 5 V +1 CR +1 02/24/20, 08:08
nice - thanks a lot -
TYPO3com voted on patch set 3 V +1 02/24/20, 08:13 Completed build in 18m 21s on Mon, 24 Feb, 08:13 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-596
-
TYPO3com voted on patch set 4 V +1 02/24/20, 08:20 Completed build in 16m 40s on Mon, 24 Feb, 08:20 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-597
-
Koen Wouters voted on patch set 5 V +1 CR +1 02/24/20, 08:24
-
TYPO3com voted on patch set 5 V +1 02/24/20, 08:27 Completed build in 23m 29s on Mon, 24 Feb, 08:27 AM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-598
-
Richard Haeser uploaded patch set 6 02/24/20, 12:40
-
Richard Haeser voted on patch set 6 V +1 CR +1 02/24/20, 12:40
-
TYPO3com voted on patch set 6 V +1 02/24/20, 13:02 Completed build in 21m 18s on Mon, 24 Feb, 01:02 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-617
-
Daniel Siepmann commented on patch set 6 02/24/20, 13:14
T3SecurityAdvisoriesWidget.php:28Shouldn't this be updated in `AbstractRssWidget` and not be overwritten? Should be the default one I guess? -
Georg Ringer voted on patch set 6 V +1 02/24/20, 13:15
-
Kay Strobach commented on patch set 6 02/24/20, 13:28
ok, question is simply custom icon or no custom icon ...T3SecurityAdvisoriesWidget.php:28Replyi think there should be a new icon for the advisories -
Oli Bartsch commented on patch set 6 02/24/20, 16:05
T3SecurityAdvisoriesWidget.php:28Reply@Daniel I'm not quite sure how this was intended by Richard. @Kay surely we could add a new icon here. But I'm not aware of the icon set and who is responsible for creating them. IMO this should not block this one to get merged before feature freeze. Let's do this afterwards with a small TASK patch. What do you think? -
Benjamin Kott commented on patch set 6 02/24/20, 16:06
T3SecurityAdvisoriesWidget.php:28Replyit´s an rss widget - please use the rss icon. -
Oli Bartsch commented on patch set 6 02/24/20, 16:09
T3SecurityAdvisoriesWidget.php:28ReplySo you are fine with the `content-widget-rss` as this is also used for the t3newsWidget? Or should I use the `dashboard-rss` icon defined in the Abstract class? -
Benjamin Kott commented on patch set 6 02/24/20, 16:13
T3SecurityAdvisoriesWidget.php:28Replythere should be no dashboard-rss icon at all. if it´s still defined as such, its a bug. all icons have been moved to content-dashboard* / content-widget* -
Oli Bartsch commented on patch set 6 02/24/20, 16:15
T3SecurityAdvisoriesWidget.php:28ReplyOke so the icon here is right. Just the icon in the abstract class is false. This should be fixed in separate Patch. Is this oke for you? -
Oli Bartsch commented on patch set 6 02/24/20, 16:39
T3SecurityAdvisoriesWidget.php:28ReplyDone -
Kay Strobach voted on patch set 6 V +1 CR +1 02/24/20, 18:00
-
Richard Haeser voted on patch set 6 V +2 CR +2 02/24/20, 19:41
-
Richard Haeser merged patch set 7 02/24/20, 19:41