63402[FEATURE] Add widget with most triggered redirects
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 911
-
Daniel Siepmann uploaded patch set 1 02/24/20, 12:46
-
Georg Ringer commented on patch set 1 02/24/20, 12:53
TopRedirects.php:31UnresolvedI would use no argument here but set a default one in the methodServices.php:13Unresolvedshould there also be a check if ext:dashboard is installed? -
Daniel Siepmann uploaded patch set 2 02/24/20, 12:54
-
TYPO3com voted on patch set 1 V +1 02/24/20, 13:08 Completed build in 16m 21s on Mon, 24 Feb, 01:08 PM Test Summary: 71584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-618
-
TYPO3com voted on patch set 2 V +1 02/24/20, 13:15 Completed build in 16m 27s on Mon, 24 Feb, 01:15 PM Test Summary: 71586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-619
-
Georg Ringer commented on patch set 2 CR -1 02/24/20, 13:37
TopRedirects.php:54dont like the hardcoded limit -
Daniel Siepmann commented on patch set 2 02/24/20, 13:52
TopRedirects.php:54Reply UnresolvedI understand, right now that's due to number of defined colours for graph. I would either need to add x more colours, or generate them on the fly. I could also re-use colours multiple times? What would you prefer? Also it's a question how much you could still understand if there would be 500 redirects on a small graph, so we need a limit. Right now there is no way to add configuration to widgets. Except I can use Symfony DI and make limit a constructor arguments. -
Susi Moog commented on patch set 2 02/28/20, 06:18
What do you think about abandoning this change in favor of the widget library approach currently discussed in #cig-dashboard? -
Oli Bartsch commented on patch set 2 02/28/20, 06:48
Services.php:1UnresolvedI think you did this to have a working example how to register a widget with PHP in the core. But as we already have a Service.yaml in this ext shouldn’t we just use it and not create this new file for just this one registration? Not really important but maybe something to think about. -
Richard Haeser commented on patch set 2 V -1 03/09/20, 09:33
For now, we don't accept new widgets for dashboard in core for v10. Widgets that can be in core, but didn't make it before feature freeze, can be added to a separate package. If you think this is a good widget, please add the request (and pull request) to https://github.com/FriendsOfTYPO3/widgets. I think it is good to abandon this change here, but add such a widget to the FriendsOfTYPO3 repository. -
Daniel Siepmann abandoned the change 03/09/20, 09:48
Will be added to external extension. Probably after new API is in place.
TopRedirects.php:23Unresolved