Review main Merged

63407[TASK] Clean up of ext:dashboard

Oli Bartsch CR +2 V +2 Hard +247 −143 updated 02/25/20, 07:03

Commit message

Before the final release of the dashboard some clean up is done.
Among others following tasks are performed:

* Add missing PHPDocs
* Remove unused methods
* Remove superfluous properties
* Unify namespace format
* Fix some typos
* Fix some formatting
* Make closures static
* NoDashboardAvailableException is removed as it is never be thrown
* Extend documentation for missing widget groups

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 24

Show 4 more files

Review log 912

  1. Oli Bartsch uploaded patch set 1 02/24/20, 21:39

  2. Nikita Hovratov commented on patch set 1 CR +1 02/24/20, 22:14

    Nice job cleaning up!
  3. TYPO3com voted on patch set 1 V +1 02/24/20, 22:15 Completed build in 34m 45s on Mon, 24 Feb, 10:15 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-661

  4. Georg Ringer commented on patch set 1 02/24/20, 22:38

    Feature-90333-Dashboard.rst:94 Unresolved

    wrap those in ` or at least *
  5. Susi Moog commented on patch set 2 02/25/20, 06:10

    Published edit on patch set 1.
  6. Oli Bartsch commented on patch set 2 02/25/20, 06:15

    Thank you Susi for taking care.
  7. TYPO3com voted on patch set 2 V -1 02/25/20, 06:25 Completed build in 14m 53s on Tue, 25 Feb, 06:25 AM Test Summary: 71702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-670

  8. TYPO3com voted on patch set 2 V +1 02/25/20, 06:49 Completed build in 53m 13s on Tue, 25 Feb, 06:49 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-670

  9. Susi Moog voted on patch set 2 V +1 CR +1 02/25/20, 06:51

  10. Stefan P commented on patch set 2 02/25/20, 06:53

    TypeOfUsersWidget.php:61 Unresolved

    Just cast instead of the ternary: (int)$admin

    be_groups.php:4 Unresolved

    static function (): void

    ext_localconf.php:7 Unresolved

    you can also add void return type. static function (): void
  11. Georg Ringer voted on patch set 2 V +2 CR +2 02/25/20, 07:03

  12. Georg Ringer merged patch set 3 02/25/20, 07:03