63407[TASK] Clean up of ext:dashboard
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 24
- typo3/sysext/core/Documentation/Changelog/master/Feature-90333-Dashboard.rst1+12 −10
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+9 −7
- typo3/sysext/dashboard/Classes/Exception/NoDashboardAvailableException.phpdeleted+0 −26
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/AdditionalCssInterface.php+0 −1
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/AdditionalJavaScriptInterface.php+0 −1
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/EventDataInterface.php+1 −2
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/RequireJsModuleInterface.php+0 −1
- typo3/sysext/dashboard/Classes/Widgets/Interfaces/WidgetInterface.php+11 −6
- typo3/sysext/dashboard/Classes/Widgets/AbstractBarChartWidget.php+10 −1
- typo3/sysext/dashboard/Classes/Widgets/AbstractChartWidget.php+9 −9
- typo3/sysext/dashboard/Classes/Widgets/AbstractCtaButtonWidget.php+31 −0
- typo3/sysext/dashboard/Classes/Widgets/AbstractDoughnutChartWidget.php+10 −3
- typo3/sysext/dashboard/Classes/Widgets/AbstractListWidget.php+38 −6
- typo3/sysext/dashboard/Classes/Widgets/AbstractNumberWithIconWidget.php+12 −13
- typo3/sysext/dashboard/Classes/Widgets/AbstractRssWidget.php+27 −11
- typo3/sysext/dashboard/Classes/Widgets/AbstractWidget.php+26 −2
- typo3/sysext/dashboard/Classes/Widgets/FailedLoginsWidget.php+23 −28
- typo3/sysext/dashboard/Classes/Widgets/SysLogErrorsWidget.php+17 −9
- typo3/sysext/dashboard/Classes/Widgets/T3NewsWidget.php+0 −1
- typo3/sysext/dashboard/Classes/Widgets/T3SecurityAdvisoriesWidget.php+0 −1
Review log 912
-
Oli Bartsch uploaded patch set 1 02/24/20, 21:39
-
Nikita Hovratov commented on patch set 1 CR +1 02/24/20, 22:14
Nice job cleaning up! -
TYPO3com voted on patch set 1 V +1 02/24/20, 22:15 Completed build in 34m 45s on Mon, 24 Feb, 10:15 PM Test Summary: 71601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-661
-
Georg Ringer commented on patch set 1 02/24/20, 22:38
Feature-90333-Dashboard.rst:94Unresolvedwrap those in ` or at least * -
Susi Moog commented on patch set 2 02/25/20, 06:10
Published edit on patch set 1. -
Oli Bartsch commented on patch set 2 02/25/20, 06:15
Thank you Susi for taking care. -
TYPO3com voted on patch set 2 V -1 02/25/20, 06:25 Completed build in 14m 53s on Tue, 25 Feb, 06:25 AM Test Summary: 71702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-670
-
TYPO3com voted on patch set 2 V +1 02/25/20, 06:49 Completed build in 53m 13s on Tue, 25 Feb, 06:49 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-670
-
Susi Moog voted on patch set 2 V +1 CR +1 02/25/20, 06:51
-
Stefan P commented on patch set 2 02/25/20, 06:53
TypeOfUsersWidget.php:61UnresolvedJust cast instead of the ternary: (int)$adminbe_groups.php:4Unresolvedstatic function (): voidext_localconf.php:7Unresolvedyou can also add void return type. static function (): void -
Georg Ringer voted on patch set 2 V +2 CR +2 02/25/20, 07:03
-
Georg Ringer merged patch set 3 02/25/20, 07:03