Review main Merged

63408[BUGFIX] Initialize more properties of PageLayoutView

Georg Ringer CR +2 V +2 Easy +2 −0 updated 02/25/20, 08:44

Commit message

With #78450 the StandardContentPreviewRenderer creates an instance of
the  `PageLayoutView` to keep the existing hooks alive.
However 2 more properties need to be filled to improve the
compatibility.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Claus Due +1
    • Oli Bartsch +1
    • Christian Eßl +1
    • Susi Moog +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Susi Moog +1

Issues 1

Files 1

Review log 1214

  1. Georg Ringer uploaded patch set 1 02/25/20, 07:19

  2. Georg Ringer updated the commit message in patch set 2 02/25/20, 07:28

  3. Georg Ringer commented on patch set 2 02/25/20, 07:29

    This change is ready for review.
  4. Claus Due voted on patch set 2 CR +1 02/25/20, 07:30

  5. Susi Moog voted on patch set 2 CR +1 02/25/20, 07:30

  6. Christian Eßl voted on patch set 2 CR +1 02/25/20, 07:36

  7. Oli Bartsch voted on patch set 2 CR +1 02/25/20, 07:40

  8. Oli Bartsch voted on patch set 2 V +1 02/25/20, 07:42

  9. TYPO3com voted on patch set 1 V +1 02/25/20, 07:54 Completed build in 30m 45s on Tue, 25 Feb, 07:54 AM Test Summary: 71996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-678

  10. Susi Moog voted on patch set 2 V +1 02/25/20, 08:20

  11. Susi Moog commented on patch set 2 02/25/20, 08:20

    (verified with debugging, without gridelements or anything)
  12. Oliver Hader voted on patch set 2 V +2 CR +2 02/25/20, 08:23

  13. Oliver Hader merged patch set 3 02/25/20, 08:23

  14. TYPO3com voted on patch set 2 V +1 02/25/20, 08:44 Completed build in 47m 09s on Tue, 25 Feb, 08:44 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-681