Review main Merged

63410[BUGFIX] Only render widget footer if defined and correct styling issues

Benjamin Kott CR +2 V +2 Normal +65 −45 updated 02/25/20, 12:25

Commit message

Widget footer is now only rendered if the optional footer section for
widgets is used and contains content. In addition, minor styling issues
were resolved. Templates were cleaned up again. Some extra conditions
were added to prevent empty tags.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 2442

Show 1517 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/25/20, 09:08

  2. Benjamin Kott commented on patch set 1 02/25/20, 09:12

    Widget.html:6 Unresolved

    renderings cannot be wrapped if they contain content, workaround this issue for now.

    Widget.html:7 Unresolved

    since we have no trim format view helper this seems to be the best solution for now.
  3. Daniel Siepmann voted on patch set 1 V +1 CR +1 02/25/20, 09:14

  4. Christian Eßl voted on patch set 1 CR +1 02/25/20, 09:22

  5. Björn Jacob updated the commit message in patch set 2 02/25/20, 09:30

  6. Björn Jacob voted on patch set 2 CR +1 02/25/20, 09:30

  7. TYPO3com voted on patch set 1 V -1 02/25/20, 09:34 Completed build in 22m 53s on Tue, 25 Feb, 09:34 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-686

  8. Oli Bartsch commented on patch set 2 V -1 02/25/20, 09:36

    On it
  9. Claus Due commented on patch set 2 02/25/20, 09:40

    ChartWidget.html:4

    Bit of unnecessary whitespace changes in this and other files.
  10. Benjamin Kott commented on patch set 2 02/25/20, 09:45

    ChartWidget.html:4 Reply Unresolved

    intended change to have streamlined formatting across all widget templates.
  11. Oli Bartsch uploaded patch set 3 02/25/20, 09:45

  12. TYPO3com voted on patch set 2 V -1 02/25/20, 09:46 Completed build in 16m 40s on Tue, 25 Feb, 09:46 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-687

  13. Benjamin Kott uploaded patch set 4 02/25/20, 09:54

  14. Benjamin Kott commented on patch set 4 02/25/20, 09:55

    not sure what's currently wrong with the compiling - build-css seem to deliver different results than a full build...
  15. Oli Bartsch voted on patch set 4 V +1 CR +1 02/25/20, 09:56

  16. Oli Bartsch voted on patch set 4 CR -1 02/25/20, 09:58

  17. Daniel Goerz voted on patch set 4 V +1 CR +1 02/25/20, 09:58

  1. Oli Bartsch wrote 02/25/20, 09:59

    Removed Code-Review-1 by Oliver Bartsch <bo@cedev.de>
  2. Oli Bartsch commented on patch set 4 CR +1 02/25/20, 09:59

    Sorry... thought I missed something.
  3. TYPO3com voted on patch set 4 V -1 02/25/20, 10:08 Completed build in 08m 48s on Tue, 25 Feb, 10:08 AM Test Summary: 10 of 58362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-689

  4. TYPO3com commented on patch set 4 02/25/20, 10:17 Completed build in 26m 59s on Tue, 25 Feb, 10:17 AM Test Summary: 10 of 58362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-689

  5. TYPO3com commented on patch set 4 02/25/20, 10:34 Completed build in 10m 17s on Tue, 25 Feb, 10:34 AM Test Summary: 26195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-691

  6. Oliver Hader rebased onto patch set 5 02/25/20, 10:42

  7. Oliver Hader commented on patch set 5 02/25/20, 10:43

    I don't know what wrong in Bamboo here... execute builds steps again locally which did not reveal any other changes...
  8. TYPO3com commented on patch set 4 02/25/20, 10:46 Completed build in 32m 40s on Tue, 25 Feb, 10:46 AM Test Summary: 26694 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-691

  9. TYPO3com voted on patch set 5 V -1 02/25/20, 10:53 Completed build in 10m 36s on Tue, 25 Feb, 10:53 AM Test Summary: 14692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-692

  10. TYPO3com commented on patch set 4 02/25/20, 10:57 Completed build in 1h 06m 04s on Tue, 25 Feb, 10:57 AM Test Summary: 27028 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-691

  11. TYPO3com commented on patch set 4 02/25/20, 11:00 Completed build in 1h 27m 57s on Tue, 25 Feb, 11:00 AM Test Summary: 71595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-689

  12. TYPO3com commented on patch set 5 02/25/20, 11:01 Completed build in 29m 41s on Tue, 25 Feb, 11:01 AM Test Summary: 1 of 48238 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-692

  13. TYPO3com commented on patch set 5 02/25/20, 11:04 Completed build in 51m 58s on Tue, 25 Feb, 11:04 AM Test Summary: 1 of 48238 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-692

  14. TYPO3com commented on patch set 4 02/25/20, 11:07 Completed build in 1h 48m 51s on Tue, 25 Feb, 11:07 AM Test Summary: 28660 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-691

  15. TYPO3com commented on patch set 5 02/25/20, 11:08 Completed build in 1h 18m 10s on Tue, 25 Feb, 11:08 AM Test Summary: 1 of 48546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-692

  16. TYPO3com commented on patch set 5 02/25/20, 11:10 Completed build in 1h 46m 17s on Tue, 25 Feb, 11:10 AM Test Summary: 1 of 48546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-692

  17. TYPO3com commented on patch set 5 02/25/20, 11:14 Completed build in 2h 18m 08s on Tue, 25 Feb, 11:14 AM Test Summary: 1 of 48546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-692

  18. Daniel Goerz voted on patch set 5 V +1 CR +1 02/25/20, 11:48

  19. TYPO3com commented on patch set 4 02/25/20, 11:51 Completed build in 3h 19m 55s on Tue, 25 Feb, 11:51 AM Test Summary: 71692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-689

  20. TYPO3com commented on patch set 4 02/25/20, 11:53 Completed build in 3h 17m 52s on Tue, 25 Feb, 11:53 AM Test Summary: 69574 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-691

  21. TYPO3com voted on patch set 5 V +1 02/25/20, 11:57 Completed build in 3h 32m 51s on Tue, 25 Feb, 11:57 AM Test Summary: 71995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-692

  22. Oliver Hader voted on patch set 5 CR +1 02/25/20, 11:57

  23. Oli Bartsch voted on patch set 5 V +1 CR +1 02/25/20, 12:00

  24. Oliver Hader voted on patch set 5 V +2 CR +2 02/25/20, 12:24

  25. Oliver Hader merged patch set 6 02/25/20, 12:25